On Wed, 16 Sep 2026 10:17:41 GMT, Jaikiran Pai <[email protected]> wrote:

>> Timofei Fedotov has updated the pull request incrementally with one 
>> additional commit since the last revision:
>> 
>>   Add regression test
>
> src/java.naming/share/classes/javax/naming/ldap/Rfc2253Parser.java line 136:
> 
>> 134:             if (rdn.size() == 0) {
>> 135:             throw new InvalidNameException(
>> 136:                 "Invalid name: \"" + name + "\" (empty RDN)");
> 
> Nit - instead of saying "empty RDN", it might be better if the error message 
> said "no attribute type/value mapping present" since the `Rdn` class and 
> method javadoc already refers to that term.

Okay

-------------

PR Review Comment: https://git.openjdk.org/jdk/pull/32648#discussion_r4024912957

Reply via email to