On Wed, 16 Sep 2026 10:25:19 GMT, Jaikiran Pai <[email protected]> wrote:
>> Timofei Fedotov has updated the pull request incrementally with one
>> additional commit since the last revision:
>>
>> Add regression test
>
> test/jdk/javax/naming/ldap/Rdn/EmptyRdnTest.java line 33:
>
>> 31: * ("returns the ... type" / "returns the ... value", never an
>> 32: * exception other than InvalidNameException at construction
>> time).
>> 33: * @run main EmptyRdnTest
>
> Given the kind of tests being run in this main method, I think it will be
> better to convert this to a junit test and run each of them as a separate
> test method.
>
> While at it, instead of explicitly referring to the test class name here,
> jtreg allows the usage of the `${test.main.class}` placeholder for test
> actions (you can find examples in existing tests in the JDK). Using that
> placeholder prevents the chances of (copy/pasted) incorrect test class name
> references which can then result in launching a completely unrelated test
> (and that can sometimes go unnoticed).
Okay, I'll update the test.
-------------
PR Review Comment: https://git.openjdk.org/jdk/pull/32648#discussion_r4025086925
