On Sun, 20 Sep 2026 13:07:25 GMT, Jaikiran Pai <[email protected]> wrote:

> Thank you Markus for the updates so far. Overall this looks good to me. I 
> have some minor comments which I have added inline.

Thank you Jaikiran for your kind review. I have integrated your requested 
changes in this PR.

> On the testing front, would it be possible to extend coverage by introducing 
> a test which uses a test specific sub-class of `InputStreamReader` which 
> overrides the `read(char[] cbuf, int off, int len)` method and verify that 
> this change does indeed continue to call that method? This test would then 
> (immediately) catch issues/regressions like the one we discussed in this PR.

There is a new test in this PR which proofs that for subclasses `read(...)` 
still is invoked.

-------------

PR Comment: https://git.openjdk.org/jdk/pull/32264#issuecomment-5858333114

Reply via email to