On Wed, Feb 05, 2003 at 03:52:46PM -0600, Dave Rolsky wrote: > On Wed, 5 Feb 2003, John Peacock wrote: > > The DateTime tests do not fully exercise DateTime::TimeZone (nor > > would you expect them to). So, how about including only those > > portions of DT::TZ which are required to pass the DT tests. At a > > quick glance, that would be TimeZone.pm, UTC.pm, Floating.pm, > > America/Chicago.pm, and America/NewYork.pm. For that matter, since > > you know exactly what tests are being performed, you can include > > exactly the portions of the OlsonDB that are used in the DateTime > > tests and no more. > > It seems rather arbitrary to only include Chicago and New York. I can > just see all the questions about why the others aren't included! > > It might be best to just skip those tests if the DateTime::TimeZone > package isn't installed, though.
I haven't looked at the code yet, but would it be useful to ask the user what their offset is from GMT, then create a dummy TZ from that offset for testing purposes? -Scott -- Jonathan Scott Duff [EMAIL PROTECTED]
