On 2/27/14, 10:26 AM, Zack Weinberg wrote:
Does that mean a patch to squelch the uninitialized variable warnings in layout will now be accepted? Those are the only warnings in layout on my (Linux, debug) builds.
configure.in sets gcc -Wno-error=maybe-uninitialized, but perhaps it should simply -Wno-maybe-uninitialized?
btw, now that gcc has -Wmaybe-uninitialized and clang has -Wsometimes-uninitialized, their -Wuninitialized warnings have almost no false positives. In fact, mozilla-central has had zero -Wuninitialized warnings on OS X and only one on Android gcc-4.8 and gcc-4.6 since Janury 6. Admittedly, the Android warning is a false positive, but is forgivable because it requires tracking member variable usage across multiple member functions (and the fix actually simplifies the code). :)
In conclusion, enabling -Werror=uninitialized is actually in the realm of possibility!
chris _______________________________________________ dev-platform mailing list dev-platform@lists.mozilla.org https://lists.mozilla.org/listinfo/dev-platform
