Github user cshannon commented on a diff in the pull request:

    https://github.com/apache/activemq-artemis/pull/2191#discussion_r204819939
  
    --- Diff: 
artemis-core-client/src/main/java/org/apache/activemq/artemis/core/protocol/core/impl/ActiveMQSessionContext.java
 ---
    @@ -822,6 +833,20 @@ public void resetMetadata(HashMap<String, String> 
metaDataToSend) {
           }
        }
     
    +   @Override
    +   public int getDefaultConsumerWindowSize(SimpleString address) throws 
ActiveMQException {
    +      if (defaultConsumerWindowSize != null) {
    +         return defaultConsumerWindowSize;
    +      } else if 
(sessionChannel.supports(PacketImpl.SESS_CONS_WINDOW_SIZE_RESP, 
getServerVersion())) {
    +         Packet packet = sessionChannel.sendBlocking(new 
ConsumerWindowSizeQueryMessage(address), PacketImpl.SESS_CONS_WINDOW_SIZE_RESP);
    +         ConsumerWindowSizeQueryResponseMessage response = 
(ConsumerWindowSizeQueryResponseMessage) packet;
    --- End diff --
    
    @michaelandrepearce - yes I could probably just extend the 
SessionQueueQueryResponseMessage and create a 
SessionQueueQueryResponseMessage_V4 and add that info to it...I will go ahead 
and do that and rework this


---

Reply via email to