Github user cshannon commented on a diff in the pull request:
https://github.com/apache/activemq-artemis/pull/2191#discussion_r204819904
--- Diff:
artemis-core-client/src/main/java/org/apache/activemq/artemis/core/client/impl/ServerLocatorImpl.java
---
@@ -347,7 +347,7 @@ private ServerLocatorImpl(final Topology topology,
minLargeMessageSize = ActiveMQClient.DEFAULT_MIN_LARGE_MESSAGE_SIZE;
- consumerWindowSize = ActiveMQClient.DEFAULT_CONSUMER_WINDOW_SIZE;
+ consumerWindowSize = -1;
--- End diff --
I can change it back but I was using -1 to figure out whether or not the
value was set. The issue is that if someone manually wants to set the client
to the same value as that constant then it will always be overriden by the
default from the server. The idea is if the client sets the value that should
be used instead....Not sure how to get around that without adding another flag
to indicate the user overrode the value (or set it to null by default)
---
