Github user michaelandrepearce commented on a diff in the pull request:
https://github.com/apache/activemq-artemis/pull/2191#discussion_r204908501
--- Diff:
artemis-core-client/src/main/java/org/apache/activemq/artemis/core/protocol/core/impl/wireformat/SessionQueueQueryResponseMessage_V4.java
---
@@ -0,0 +1,151 @@
+/*
+ * Licensed to the Apache Software Foundation (ASF) under one or more
+ * contributor license agreements. See the NOTICE file distributed with
+ * this work for additional information regarding copyright ownership.
+ * The ASF licenses this file to You under the Apache License, Version 2.0
+ * (the "License"); you may not use this file except in compliance with
+ * the License. You may obtain a copy of the License at
+ *
+ * http://www.apache.org/licenses/LICENSE-2.0
+ *
+ * Unless required by applicable law or agreed to in writing, software
+ * distributed under the License is distributed on an "AS IS" BASIS,
+ * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
+ * See the License for the specific language governing permissions and
+ * limitations under the License.
+ */
+package org.apache.activemq.artemis.core.protocol.core.impl.wireformat;
+
+import org.apache.activemq.artemis.api.core.ActiveMQBuffer;
+import org.apache.activemq.artemis.api.core.RoutingType;
+import org.apache.activemq.artemis.api.core.SimpleString;
+import org.apache.activemq.artemis.api.core.client.ActiveMQClient;
+import org.apache.activemq.artemis.api.core.client.ClientSession;
+import org.apache.activemq.artemis.core.client.impl.QueueQueryImpl;
+import org.apache.activemq.artemis.core.server.QueueQueryResult;
+
+public class SessionQueueQueryResponseMessage_V4 extends
SessionQueueQueryResponseMessage_V3 {
+
+ protected int defaultConsumerWindowSize;
+
+ public SessionQueueQueryResponseMessage_V4(final QueueQueryResult
result) {
+ this(result.getName(), result.getAddress(), result.isDurable(),
result.isTemporary(), result.getFilterString(), result.getConsumerCount(),
result.getMessageCount(), result.isExists(), result.isAutoCreateQueues(),
result.isAutoCreated(), result.isPurgeOnNoConsumers(), result.getRoutingType(),
result.getMaxConsumers(), result.isExclusive(), result.isLastValue(),
result.getDefaultConsumerWindowSize());
--- End diff --
I would keep it as is. I think a dicussion is needes as currently having
the version and typing means there is a strong contract, moving to a map
removes the strong versioned contract.
---
