> On Apr 20, 2021, at 9:13 PM, Arjun Ray <[email protected]> wrote:
> Getting rid of std::auto_ptr is only staving off an immediate problem > (which really should have been addressed years ago, considering how > simple the fix is.) But there are other serious issues with the code > base that also need to be addressed, sooner rather than later. Understood. I think we can take it in phases and seek to attract additional C++ developers to provide insight to best practices with modern changes to the language and standard libraries. > If something as not much more than cosmetic as replacing std::auto_ptr > doesn't find favor with the gatekeepers, I don't fancy the chances for > any serious changes. Keeping PR’s and changes small allows changes to be reviewed by a wider audience quickly and I think you’d see velocity pick up on the wider changes. > | 1. Create a clone of this git repo activemq-cpp > <https://github.com/apache/activemq-cpp> > > This clone is in github itself, right? Yes, clone to a repository in under your profile and PR’s are automatically detected and a click away. > | 2. Create a branch (using the JIRA name is good ie AMQCPP-664) > > And this is in a local copy of my github clone, right? Rough sketch of the git flow: 1. Clone the repo into a repository in your GitHub profile 2. Checkout that git repo locally $ git clone https://github.com/yourprofile/activmeq.git <https://github.com/yourprofile/activmeq.git> 3. Add upstream as a remote: $ git remote -v (Observe only origin exists pointing to your personal repo) $ git remote add upstream https://github.com/activemq/activemq.git $ git remote -v (Observe the upstream apache repo is listed) Create a branch 4. $ git checkout -b AMQ-xxxx 5. Make changes.. and commit 6. $ git push origin AMQ-xxxx 7. You can now click on Create Pull Request in GitHub
