Not yet. Will do soon :). J.
On Wed, Sep 4, 2019 at 3:51 PM Driesprong, Fokko <fo...@driesprong.frl> wrote: > Did you find any time to fix this Jarek? Would be great to get this up and > running again. > > Cheers, Fokko > > Op wo 28 aug. 2019 om 14:28 schreef Jarek Potiuk <jarek.pot...@polidea.com > >: > > > Apologies - I broke it at some point of time when introducing new CI > > approach. This one commit that Kaxil mentions was supposed to fix it :). > I > > think it was broken afterwards or during rebase. > > The problem with codecov is that until you merge it to master you never > > know if it finally works or not (it reports difference vs. relative good > > "master" result"). It's a bit hit-or-miss. > > > > I will take a look and fix it shortly. > > > > J. > > > > > > > > On Wed, Aug 28, 2019 at 7:52 AM Kaxil Naik <kaxiln...@gmail.com> wrote: > > > > > It seems to be not doing much as it is unable to find a dependency. > > > > > > _____ _ > > > 10217 / ____| | | > > > 10218| | ___ __| | ___ ___ _____ __ > > > 10219| | / _ \ / _` |/ _ \/ __/ _ \ \ / / > > > 10220| |___| (_) | (_| | __/ (_| (_) \ V / > > > 10221 \_____\___/ \__,_|\___|\___\___/ \_/ > > > 10222 Bash-8a28df4 > > > 10223 > > > 10224 > > > 10225==> Travis CI detected. > > > 10226 project root: . > > > 10227 Yaml not found, that's ok! Learn more at > > > http://docs.codecov.io/docs/codecov-yaml > > > 10228==> Running gcov in . (disable via -X gcov) > > > 10229==> Python coveragepy not found > > > 10230==> Searching for coverage reports in: > > > 10231 + . > > > 10232--> No coverage report found. > > > 10233 Please visit http://docs.codecov.io/docs/supported-languages > > > 10234+ in_container_script_end > > > > > > > > > On Wed, Aug 28, 2019 at 12:51 PM Kaxil Naik <kaxiln...@gmail.com> > wrote: > > > > > > > The change seems to be that the CodeCov is now embedded inside tests > > and > > > > is run at last. > > > > > > > > Check this: > https://travis-ci.org/apache/airflow/jobs/577789685#L10216 > > > > > > > > > > > > > > > > On Wed, Aug 28, 2019 at 12:49 PM Kaxil Naik <kaxiln...@gmail.com> > > wrote: > > > > > > > >> Looks like this commit: > > > >> > > > > > > https://github.com/apache/airflow/commit/8b41c3f12944c9b87fd04bd7137ba03d7e5a502f#diff-2eeaed663bd0d25b7e608891384b7298 > > > changed > > > >> it. > > > >> > > > >> > > > >> > > > >> > > > >> > > > >> On Wed, Aug 28, 2019 at 12:39 PM Driesprong, Fokko > > <fo...@driesprong.frl > > > > > > > >> wrote: > > > >> > > > >>> I've noticed that the latest reports are at 2019-08-08: > > > >>> https://codecov.io/github/apache/airflow?branch=master > > > >>> > > > >>> But I don't see any commits that day that changed any significantly > > on > > > >>> that > > > >>> area: > > > >>> > > > >>> > > > > > > https://github.com/apache/airflow/commits/master?after=f40b3b5dd766f271447fef282bb6681bff575814+139 > > > >>> > > > >>> Op wo 28 aug. 2019 om 13:34 schreef Driesprong, Fokko > > > >>> <fo...@driesprong.frl > > > >>> >: > > > >>> > > > >>> > Hi Kaxil, > > > >>> > > > > >>> > I did notice that the coveralls library is gone, we had this > before > > > to > > > >>> > push it to codecov. I know that the names are different, and it > is > > > >>> > confusing, I tried to remove it before: > > > >>> > https://github.com/apache/airflow/pull/3295 > > > >>> > > > > >>> > Let us see if it works again when reenabling this library: > > > >>> > https://github.com/apache/airflow/pull/5936 > > > >>> > > > > >>> > A lot has changed recently with all the tests, but it might be > that > > > the > > > >>> > current CI pipeline doesn't contain this step anymore, but I > lost a > > > >>> bit of > > > >>> > track recently. > > > >>> > > > > >>> > Cheers, Fokko > > > >>> > > > > >>> > Op wo 28 aug. 2019 om 13:19 schreef Kaxil Naik < > > kaxiln...@gmail.com > > > >: > > > >>> > > > > >>> >> Did we remove codecov.io integration from Airflow? > > > >>> >> > > > >>> >> Previously on each PR we used to get info if the Code Coverage > > would > > > >>> >> increase/decrease by what % if it is merged. > > > >>> >> > > > >>> >> Regards, > > > >>> >> Kaxil > > > >>> >> > > > >>> > > > > >>> > > > >> > > > > > > > > > -- > > > > Jarek Potiuk > > Polidea <https://www.polidea.com/> | Principal Software Engineer > > > > M: +48 660 796 129 <+48660796129> > > [image: Polidea] <https://www.polidea.com/> > > > -- Jarek Potiuk Polidea <https://www.polidea.com/> | Principal Software Engineer M: +48 660 796 129 <+48660796129> [image: Polidea] <https://www.polidea.com/>
