Looks great Gerard! I think maybe one last pass with Superset's docs. Side comment. I really like that SIP's of superset end up as Github Issues. They even have template for it. Maybe we should do the same? Seems that we are gravitating towards "Github heads-on" recently - Github Actions, Github Registry, Github Issues, GitHub Discussions .... I also applied for Github CodeSpaces access .
J. On Tue, Aug 25, 2020 at 2:27 AM Gerard Casas Saez <gcasass...@twitter.com.invalid> wrote: > Thanks Max for sharing. I will take a look and check what we should reuse > from there as well. > > I also took a pass to the comments and edited + accepted suggestions. Let > me know: > > https://docs.google.com/document/d/1hJDodc1xl4ixswPzAV4IAQu74sLnOOKjqecPgthLta4/edit > > Will try to read the document sent by Max tomorrow and add details based on > that as needed. If someone wants to do that before tomorrow afternoon, > please let me know! > > > Gerard Casas Saez > Twitter | Cortex | @casassaez <http://twitter.com/casassaez> > > > On Mon, Aug 24, 2020 at 3:53 PM Maxime Beauchemin < > maximebeauche...@gmail.com> wrote: > > > For reference, here's SIP-0 (Superset Improvement Proposal 0) which > defines > > the SIP process for Apache Superset: > > https://github.com/apache/incubator-superset/issues/5602 > > > > We also have a GitHub issue template for it: > > > > > https://github.com/apache/incubator-superset/blob/master/.github/ISSUE_TEMPLATE/sip.md > > > > and this kanban project to track the status of each SIP: > > https://github.com/apache/incubator-superset/projects/7 > > > > Max > > > > On Sun, Aug 23, 2020 at 3:38 AM Tomasz Urbaszek <turbas...@apache.org> > > wrote: > > > > > Thanks Gerard for this proposal, it looks good! I added few > suggestions. > > > > > > Bests, > > > Tomek > > > > > > On Fri, Aug 21, 2020 at 10:49 PM Kaxil Naik <kaxiln...@gmail.com> > wrote: > > > > > > > Thanks Gerard, added my suggestions. > > > > > > > > On Fri, Aug 21, 2020 at 7:17 PM Jarek Potiuk < > jarek.pot...@polidea.com > > > > > > > wrote: > > > > > > > > > It's super cool indeed! I already made my suggestions and > comments. I > > > > think > > > > > there is no need to do vote - lazy consensus should be applied in > > this > > > > case > > > > > I think when you think is ready :). > > > > > > > > > > J. > > > > > > > > > > On Fri, Aug 21, 2020 at 8:12 PM Gerard Casas Saez > > > > > <gcasass...@twitter.com.invalid> wrote: > > > > > > > > > > > I do have access, I will add it there once there's consensus (not > > > sure > > > > if > > > > > > we should submit this to vote). > > > > > > Gerard Casas Saez > > > > > > Twitter | Cortex | @casassaez <http://twitter.com/casassaez> > > > > > > > > > > > > > > > > > > On Fri, Aug 21, 2020 at 12:09 PM Ry Walker <r...@rywalker.com> > > wrote: > > > > > > > > > > > > > Proposal looks good to me Gerard - thanks for putting this > > > together! > > > > > > > > > > > > > > -Ry > > > > > > > > > > > > > > On Fri, Aug 21, 2020 at 1:41 PM Gerard Casas Saez > > > > > > > <gcasass...@twitter.com.invalid> wrote: > > > > > > > > > > > > > > > Hi folks, > > > > > > > > > > > > > > > > I realized that the AIP process was not super clear at > times. I > > > was > > > > > > lucky > > > > > > > > when I proposed AIP-31 that Dan and Tomek guided me through > > most > > > of > > > > > the > > > > > > > > process themselves, but I realize this may be confusing for > new > > > > > members > > > > > > > of > > > > > > > > the community. For that reason and after discussing this with > > > Kamil > > > > > and > > > > > > > > Jarek on Slack > > > > > > > > < > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > https://docs.google.com/document/d/1hJDodc1xl4ixswPzAV4IAQu74sLnOOKjqecPgthLta4/edit?usp=sharing > > > > > > > > >. > > > > > > > > I'm proposing to extend the AIP page to include a description > > of > > > > the > > > > > > > > lifecycle of the AIP. > > > > > > > > > > > > > > > > I put a doc together with some of my understanding as a new > > > member > > > > > and > > > > > > > how > > > > > > > > I saw the process for AIP-31. Suggestions are welcome and > > > > encouraged! > > > > > > > > > > > > > > > > > > > > > > > > Document proposal: > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > https://docs.google.com/document/d/1hJDodc1xl4ixswPzAV4IAQu74sLnOOKjqecPgthLta4/edit?usp=sharing > > > > > > > > < > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > https://docs.google.com/document/d/1hJDodc1xl4ixswPzAV4IAQu74sLnOOKjqecPgthLta4/edit?usp=sharing > > > > > > > > > > > > > > > > > > > > > > > > > Let me know what you think about this :D > > > > > > > > > > > > > > > > Best, > > > > > > > > > > > > > > > > Gerard Casas Saez > > > > > > > > Twitter | Cortex | @casassaez <http://twitter.com/casassaez> > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > -- > > > > > > > > > > Jarek Potiuk > > > > > Polidea <https://www.polidea.com/> | Principal Software Engineer > > > > > > > > > > M: +48 660 796 129 <+48660796129> > > > > > [image: Polidea] <https://www.polidea.com/> > > > > > > > > > > > > > > > -- Jarek Potiuk Polidea <https://www.polidea.com/> | Principal Software Engineer M: +48 660 796 129 <+48660796129> [image: Polidea] <https://www.polidea.com/>
