Ah cool. So I think we can drop sdist indeed :). I think if it is the only problem found till Monday, I would be OK in dropping sdist from 2.0.0 release then - if this is going to slow down the process by a week. I am happy to change my vote if others are happy with it.
Regardless, I updated our tests: https://github.com/apache/airflow/pull/13033. During the tests we installed airflow always from .whl only providers were installed from either wheel or sdist. Now once it works, both airflow and providers should be installed using the same package format. J. On Sat, Dec 12, 2020 at 11:15 AM Ash Berlin-Taylor <a...@apache.org> wrote: > The BigQuery dataset PyPi publishes has a file.type column: > > https://packagingpython.org/guides/analyzing-pypi-package-downloads/ > <https://packaging.python.org/guides/analyzing-pypi-package-downloads/> > > Since we started publishing wheels (1.10.3) the wheel almost all of the > downloads. This 2020-12-01 (picked randomly): > > 1.10.12 bdist_wheel 10831 > 1.10.12 sdist 12 > 1.10.13 bdist_wheel 3145 > 1.10.13 sdist 32 > 1.10.4 sdist 2 > 1.10.4 bdist_wheel 2399 > 1.10.3 bdist_wheel 1079 > 1.10.3 sdist 3 > > > > On Sat, 12 Dec, 2020 at 10:50, Jarek Potiuk <jarek.pot...@polidea.com> > wrote: > > Update: not provider packages, but the packages that airflow depends on. > indeed all our provider/airflow package are pure python and as long as > there are no "special cases" like anyone requiring source packages (for > whatever reason) they *should* work. > > On Sat, Dec 12, 2020 at 10:48 AM Jarek Potiuk <jarek.pot...@polidea.com> > wrote: > >> It might well be, yes, that we have no such problem in the airflow >> package. I referred more to the provider packages. I think it would like to >> hear from the user why sdist was used in this case. >> Also, I believe there are some distros Gentoo, that always use sources >> for everything it can (and I am not sure if they would work with .whl only). >> >> I am not against removing it, just want to be sure there are no >> unforeseen consequences. Unfortunately, there are no stats to show which >> type of packages are downloaded :( >> https://pypistats.org/packages/apache-airflow >> >> J, >> >> On Sat, Dec 12, 2020 at 10:38 AM Ash Berlin-Taylor <a...@apache.org> >> wrote: >> >>> On Sat, 12 Dec, 2020 at 10:34, Jarek Potiuk <jarek.pot...@polidea.com> >>> wrote: >>> >>> So I think there will be systems where sdist is used automatically >>> because the host system is not as close to what we use when build wheels. >>> >>> >>> I think that is only a problem for wheels with binary components,but our >>> wheels are not -- they are universal (i.e. just contain pure python). >>> >> >> >> -- >> >> Jarek Potiuk >> Polidea <https://www.polidea.com/> | Principal Software Engineer >> >> M: +48 660 796 129 <+48660796129> >> [image: Polidea] <https://www.polidea.com/> >> >> > > -- > > Jarek Potiuk > Polidea <https://www.polidea.com/> | Principal Software Engineer > > M: +48 660 796 129 <+48660796129> > [image: Polidea] <https://www.polidea.com/> > > -- Jarek Potiuk Polidea <https://www.polidea.com/> | Principal Software Engineer M: +48 660 796 129 <+48660796129> [image: Polidea] <https://www.polidea.com/>
