+1 (non-binding) Below is the list of items I have tested: - Tested regression DAG with Celery and k8s executor. - Tested issues 37497 <https://github.com/apache/airflow/pull/37497> 372027 <https://github.com/apache/airflow/pull/37207> 37254 <https://github.com/apache/airflow/pull/37254> 37205 <https://github.com/apache/airflow/pull/37205> . - UI sanity.
Regards, Rahul Vats 9953794332 On Sun, 25 Feb 2024 at 18:06, Jarek Potiuk <ja...@potiuk.com> wrote: > Small comment. I raise it here because it's been discussed in the ASF > discussions about "advisors" (which is a new initiative in the Foundation > that I am taking part of). > > It's really good if the (+1) is accompanied by "what did I do" - this is > why I always try to explain what kind of testing I've done. > > Those +1s are not only a "chore" we need to do but there is a good reason > why we are doing it. We already had a security issue with our CI/Github > Actions last year that **could** have resulted in someone sneaking in a > malicious code in our releases - but thanks to our +1, checksum, > signatures, sources, licences - and recently reproducible checks, it was > not really exploitable (the way how release process is designed and > mandated by the ASF is precisely to prevent this kind of problems, but also > to provide legal protection (to both the PMC members, and ASF foundation). > Similarly when non-binding votes are cast it would be great to see the > broad scope of tests one did with it (and in this case our "Status issue" > is even better :). > > I've learned - as part of my "Advisor" discussion, that some PMCs even went > as far as not counting +1s if they did not have an explanation of what had > been tested. That's a bit far, but it shows that the "+1" we do at the > release time is not really a "cargo cult" - it is something that has > tangible value and if we understand why we are doing it, it's coll. > > The PR where I am proposing a short explanation about the release process > for the future "Advisors" of the ASF is here > https://github.com/apache/comdev-working-groups/pull/16/files > > So kind request for the future - let's explain what we tested :). > > BTW. Any ASF member here is also encouraged to join the advisor's working > group - it looks like we are starting something pretty cool and useful - > https://github.com/apache/comdev-working-groups/tree/main/wg-advisors > > J. > > On Sun, Feb 25, 2024 at 1:18 PM Elad Kalif <elad...@apache.org> wrote: > > > +1 binding > > > > On Sun, Feb 25, 2024 at 12:03 PM Phani Kumar > > <phani.ku...@astronomer.io.invalid> wrote: > > > > > +1 non-binding > > > > > > On Sun, Feb 25, 2024 at 4:00 AM Hussein Awala <huss...@awala.fr> > wrote: > > > > > > > +1 (binding) ran the same checks and tests as the RC2; all look good. > > > > > > > > On Sat, Feb 24, 2024 at 8:22 PM Jarek Potiuk <ja...@potiuk.com> > wrote: > > > > > > > > > +1 (binding): installed RC3 and ran a few DAGs. Tested > > reproducibility, > > > > > licences, checksums, signatures. Everything looks good ! > > > > > > > > > > Side comment: I also found two edge-cases of edge-cases :) - where > > > > specific > > > > > conditions could lead to either failure when running docker-based > > > package > > > > > preparation or **slightly** not reproducible build (with 1 more > .txt > > > file > > > > > added) both have PRs (one merged > > > > > https://github.com/apache/airflow/pull/37678, one waits for > review: > > > > > https://github.com/apache/airflow/pull/37679) but they have no > > impact > > > on > > > > > prepared packages (edge cases were not triggered). > > > > > > > > > > J. > > > > > > > > > > > > > > > On Sat, Feb 24, 2024 at 5:38 PM Ephraim Anierobi < > > > > > ephraimanier...@apache.org> > > > > > wrote: > > > > > > > > > > > Hey fellow Airflowers, > > > > > > > > > > > > I have cut Airflow 2.8.2rc3. This email is calling a vote on the > > > > release, > > > > > > which will last at least 30 hours, from Saturday, February 24, > 2024 > > > at > > > > > 4:30 > > > > > > pm UTC > > > > > > until Sunday, February 25, 2024, at 11:00 pm UTC > > > > > > < > > > > > > > > > > > > > > > > > > > > > https://www.timeanddate.com/worldclock/fixedtime.html?msg=8&iso=20240225T2300&p1=1440 > > > > > > >, > > > > > > and until 3 binding +1 votes have been received. > > > > > > > > > > > > The status of testing of the release is kept at > > > > > > https://github.com/apache/airflow/issues/37617 > > > > > > > > > > > > Consider this my (binding) +1. > > > > > > > > > > > > Airflow 2.8.2rc3 is available at: > > > > > > https://dist.apache.org/repos/dist/dev/airflow/2.8.2rc3/ > > > > > > > > > > > > *apache-airflow-2.8.2-source.tar.gz* is a source release that > comes > > > > with > > > > > > INSTALL instructions. > > > > > > *apache-airflow-2.8.2.tar.gz* is the binary Python "sdist" > release. > > > > > > *apache_airflow-2.8.2-py3-none-any.whl* is the binary Python > wheel > > > > > "binary" > > > > > > release. > > > > > > > > > > > > Public keys are available at: > > > > > > https://dist.apache.org/repos/dist/release/airflow/KEYS > > > > > > > > > > > > Please vote accordingly: > > > > > > > > > > > > [ ] +1 approve > > > > > > [ ] +0 no opinion > > > > > > [ ] -1 disapprove with the reason > > > > > > > > > > > > Only votes from PMC members are binding, but all members of the > > > > community > > > > > > are encouraged to test the release and vote with "(non-binding)". > > > > > > > > > > > > The test procedure for PMC members is described in: > > > > > > > > > > > > > > > > > > > > > > > > > > > https://github.com/apache/airflow/blob/main/dev/README_RELEASE_AIRFLOW.md\#verify-the-release-candidate-by-pmc-members > > > > > > > > > > > > The test procedure for and Contributors who would like to test > this > > > RC > > > > is > > > > > > described in: > > > > > > > > > > > > > > > > > > > > > > > > > > > https://github.com/apache/airflow/blob/main/dev/README_RELEASE_AIRFLOW.md\#verify-the-release-candidate-by-contributors > > > > > > > > > > > > > > > > > > Please note that the version number excludes the `rcX` string, so > > > it's > > > > > now > > > > > > simply 2.8.2. This will allow us to rename the artifact without > > > > modifying > > > > > > the artifact checksums when we actually release. > > > > > > > > > > > > Release Notes: > > > > > > > https://github.com/apache/airflow/blob/2.8.2rc3/RELEASE_NOTES.rst > > > > > > > > > > > > For information on what goes into a release please see: > > > > > > > > > > > > > > > > > > > > > > > > > > > https://github.com/apache/airflow/blob/main/dev/WHAT_GOES_INTO_THE_NEXT_RELEASE.md > > > > > > > > > > > > Changes since 2.8.2rc2: > > > > > > > > > > > > *Bugs*: > > > > > > - Fix regression on trigger form error display on form validation > > > > > (#37672) > > > > > > > > > > > > *Miscellaneous*: > > > > > > - Install latest docker ``CLI`` instead of specific one (#37651) > > > > > > > > > > > > Cheers, > > > > > > Ephraim > > > > > > > > > > > > > > > > > > > > >
