+1 (non-binding) Tested the PRs I contributed as fixes and can confirm all of this is working: - #37672 Fix regression on trigger form error display on form validation - #37497 Allow pre-population of trigger form values via URL parameters - #37063 Bugfix Triggering DAG with parameters is mandatory when show_trigger_form_if_no_params is enabled - and checked that some small docs changes are also correctly on branch, not critical to code
Mit freundlichen Grüßen / Best regards Jens Scheffler Alliance: Enabler - Tech Lead (XC-AS/EAE-ADA-T) Robert Bosch GmbH | Hessbruehlstraße 21 | 70565 Stuttgart-Vaihingen | GERMANY | http://www.bosch.com/ Tel. +49 711 811-91508 | Mobil +49 160 90417410 | jens.scheff...@de.bosch.com Sitz: Stuttgart, Registergericht: Amtsgericht Stuttgart, HRB 14000; Aufsichtsratsvorsitzender: Prof. Dr. Stefan Asenkerschbaumer; Geschäftsführung: Dr. Stefan Hartung, Dr. Christian Fischer, Dr. Markus Forschner, Stefan Grosch, Dr. Markus Heyn, Dr. Frank Meyer, Dr. Tanja Rückert -----Original Message----- From: Rahul Vats <rah.sharm...@gmail.com> Sent: Sonntag, 25. Februar 2024 14:36 To: dev@airflow.apache.org Subject: Re: [VOTE] Release Airflow 2.8.2 from 2.8.2rc3 +1 (non-binding) Below is the list of items I have tested: - Tested regression DAG with Celery and k8s executor. - Tested issues 37497 <https://github.com/apache/airflow/pull/37497> 372027 <https://github.com/apache/airflow/pull/37207> 37254 <https://github.com/apache/airflow/pull/37254> 37205 <https://github.com/apache/airflow/pull/37205> . - UI sanity. Regards, Rahul Vats 9953794332 On Sun, 25 Feb 2024 at 18:06, Jarek Potiuk <ja...@potiuk.com> wrote: > Small comment. I raise it here because it's been discussed in the ASF > discussions about "advisors" (which is a new initiative in the > Foundation that I am taking part of). > > It's really good if the (+1) is accompanied by "what did I do" - this > is why I always try to explain what kind of testing I've done. > > Those +1s are not only a "chore" we need to do but there is a good > reason why we are doing it. We already had a security issue with our > CI/Github Actions last year that **could** have resulted in someone > sneaking in a malicious code in our releases - but thanks to our +1, > checksum, signatures, sources, licences - and recently reproducible > checks, it was not really exploitable (the way how release process is > designed and mandated by the ASF is precisely to prevent this kind of > problems, but also to provide legal protection (to both the PMC members, and > ASF foundation). > Similarly when non-binding votes are cast it would be great to see the > broad scope of tests one did with it (and in this case our "Status issue" > is even better :). > > I've learned - as part of my "Advisor" discussion, that some PMCs even > went as far as not counting +1s if they did not have an explanation of > what had been tested. That's a bit far, but it shows that the "+1" we > do at the release time is not really a "cargo cult" - it is something > that has tangible value and if we understand why we are doing it, it's coll. > > The PR where I am proposing a short explanation about the release > process for the future "Advisors" of the ASF is here > https://gith/ > ub.com%2Fapache%2Fcomdev-working-groups%2Fpull%2F16%2Ffiles&data=05%7C > 02%7CJens.Scheffler%40de.bosch.com%7Cce83e167cb4d4d42c86e08dc3606d520% > 7C0ae51e1907c84e4bbb6d648ee58410f4%7C0%7C0%7C638444650170669523%7CUnkn > own%7CTWFpbGZsb3d8eyJWIjoiMC4wLjAwMDAiLCJQIjoiV2luMzIiLCJBTiI6Ik1haWwi > LCJXVCI6Mn0%3D%7C0%7C%7C%7C&sdata=Bs8MmhuPfAA5tvphz%2BCjZH5qsq%2F2p5cu > %2B3avlAuyvuA%3D&reserved=0 > > So kind request for the future - let's explain what we tested :). > > BTW. Any ASF member here is also encouraged to join the advisor's > working group - it looks like we are starting something pretty cool > and useful - > https://gith/ > ub.com%2Fapache%2Fcomdev-working-groups%2Ftree%2Fmain%2Fwg-advisors&da > ta=05%7C02%7CJens.Scheffler%40de.bosch.com%7Cce83e167cb4d4d42c86e08dc3 > 606d520%7C0ae51e1907c84e4bbb6d648ee58410f4%7C0%7C0%7C63844465017067335 > 7%7CUnknown%7CTWFpbGZsb3d8eyJWIjoiMC4wLjAwMDAiLCJQIjoiV2luMzIiLCJBTiI6 > Ik1haWwiLCJXVCI6Mn0%3D%7C0%7C%7C%7C&sdata=2LovyKq257knEHEExBjxlyBHjfqk > AJSB5mFslTaRztY%3D&reserved=0 > > J. > > On Sun, Feb 25, 2024 at 1:18 PM Elad Kalif <elad...@apache.org> wrote: > > > +1 binding > > > > On Sun, Feb 25, 2024 at 12:03 PM Phani Kumar > > <phani.ku...@astronomer.io.invalid> wrote: > > > > > +1 non-binding > > > > > > On Sun, Feb 25, 2024 at 4:00 AM Hussein Awala <huss...@awala.fr> > wrote: > > > > > > > +1 (binding) ran the same checks and tests as the RC2; all look good. > > > > > > > > On Sat, Feb 24, 2024 at 8:22 PM Jarek Potiuk <ja...@potiuk.com> > wrote: > > > > > > > > > +1 (binding): installed RC3 and ran a few DAGs. Tested > > reproducibility, > > > > > licences, checksums, signatures. Everything looks good ! > > > > > > > > > > Side comment: I also found two edge-cases of edge-cases :) - > > > > > where > > > > specific > > > > > conditions could lead to either failure when running > > > > > docker-based > > > package > > > > > preparation or **slightly** not reproducible build (with 1 > > > > > more > .txt > > > file > > > > > added) both have PRs (one merged > > > > > https://eur03.safelinks.protection.outlook.com/?url=https%3A%252 > > > > > F%2Fgithub.com%2Fapache%2Fairflow%2Fpull%2F37678&data=05%7C02% > > > > > 7CJens.Scheffler%40de.bosch.com%7Cce83e167cb4d4d42c86e08dc3606 > > > > > d520%7C0ae51e1907c84e4bbb6d648ee58410f4%7C0%7C0%7C638444650170 > > > > > 677184%7CUnknown%7CTWFpbGZsb3d8eyJWIjoiMC4wLjAwMDAiLCJQIjoiV2l > > > > > uMzIiLCJBTiI6Ik1haWwiLCJXVCI6Mn0%3D%7C0%7C%7C%7C&sdata=mmTepz% > > > > > 2FK1N7naRMfrEldUFSz5Z%2FGdGKKXWMdL6v9aGc%3D&reserved=0, one > > > > > waits for > review: > > > > > https://eur03.safelinks.protection.outlook.com/?url=https%3A%252 > > > > > F%2Fgithub.com%2Fapache%2Fairflow%2Fpull%2F37679&data=05%7C02% > > > > > 7CJens.Scheffler%40de.bosch.com%7Cce83e167cb4d4d42c86e08dc3606 > > > > > d520%7C0ae51e1907c84e4bbb6d648ee58410f4%7C0%7C0%7C638444650170 > > > > > 680741%7CUnknown%7CTWFpbGZsb3d8eyJWIjoiMC4wLjAwMDAiLCJQIjoiV2l > > > > > uMzIiLCJBTiI6Ik1haWwiLCJXVCI6Mn0%3D%7C0%7C%7C%7C&sdata=8jdi7Gf > > > > > ie7zBWAvXZRTW767wg%2FJbp43FytrQ6rGYsBo%3D&reserved=0) but they > > > > > have no > > impact > > > on > > > > > prepared packages (edge cases were not triggered). > > > > > > > > > > J. > > > > > > > > > > > > > > > On Sat, Feb 24, 2024 at 5:38 PM Ephraim Anierobi < > > > > > ephraimanier...@apache.org> > > > > > wrote: > > > > > > > > > > > Hey fellow Airflowers, > > > > > > > > > > > > I have cut Airflow 2.8.2rc3. This email is calling a vote on > > > > > > the > > > > release, > > > > > > which will last at least 30 hours, from Saturday, February > > > > > > 24, > 2024 > > > at > > > > > 4:30 > > > > > > pm UTC > > > > > > until Sunday, February 25, 2024, at 11:00 pm UTC < > > > > > > > > > > > > > > > > > > > > > https://www/. > timeanddate.com%2Fworldclock%2Ffixedtime.html%3Fmsg%3D8%26iso%3D202402 > 25T2300%26p1%3D1440&data=05%7C02%7CJens.Scheffler%40de.bosch.com%7Cce8 > 3e167cb4d4d42c86e08dc3606d520%7C0ae51e1907c84e4bbb6d648ee58410f4%7C0%7 > C0%7C638444650170684290%7CUnknown%7CTWFpbGZsb3d8eyJWIjoiMC4wLjAwMDAiLC > JQIjoiV2luMzIiLCJBTiI6Ik1haWwiLCJXVCI6Mn0%3D%7C0%7C%7C%7C&sdata=%2B%2F > qWyc3IFFOgGiCMXmmcoRIuE9CwzlkO%2BAimrNTPoxw%3D&reserved=0 > > > > > > >, > > > > > > and until 3 binding +1 votes have been received. > > > > > > > > > > > > The status of testing of the release is kept at > > > > > > https://eur03.safelinks.protection.outlook.com/?url=https%3A > > > > > > %2F%2Fgithub.com%2Fapache%2Fairflow%2Fissues%2F37617&data=05 > > > > > > %7C02%7CJens.Scheffler%40de.bosch.com%7Cce83e167cb4d4d42c86e > > > > > > 08dc3606d520%7C0ae51e1907c84e4bbb6d648ee58410f4%7C0%7C0%7C63 > > > > > > 8444650170687999%7CUnknown%7CTWFpbGZsb3d8eyJWIjoiMC4wLjAwMDA > > > > > > iLCJQIjoiV2luMzIiLCJBTiI6Ik1haWwiLCJXVCI6Mn0%3D%7C0%7C%7C%7C > > > > > > &sdata=5D0Ben7CkOoRPKLvzhnKaO3el1Ee9x3A2X%2B7nX1eTxc%3D&rese > > > > > > rved=0 > > > > > > > > > > > > Consider this my (binding) +1. > > > > > > > > > > > > Airflow 2.8.2rc3 is available at: > > > > > > https://eur03.safelinks.protection.outlook.com/?url=https%3A > > > > > > %2F%2Fdist.apache.org%2Frepos%2Fdist%2Fdev%2Fairflow%2F2.8.2 > > > > > > rc3%2F&data=05%7C02%7CJens.Scheffler%40de.bosch.com%7Cce83e1 > > > > > > 67cb4d4d42c86e08dc3606d520%7C0ae51e1907c84e4bbb6d648ee58410f > > > > > > 4%7C0%7C0%7C638444650170691493%7CUnknown%7CTWFpbGZsb3d8eyJWI > > > > > > joiMC4wLjAwMDAiLCJQIjoiV2luMzIiLCJBTiI6Ik1haWwiLCJXVCI6Mn0%3 > > > > > > D%7C0%7C%7C%7C&sdata=o3VCnVP8uUSE8wYHs2Pbw%2BiY5%2BDqrgGcVO1 > > > > > > Fk2wzWHs%3D&reserved=0 > > > > > > > > > > > > *apache-airflow-2.8.2-source.tar.gz* is a source release > > > > > > that > comes > > > > with > > > > > > INSTALL instructions. > > > > > > *apache-airflow-2.8.2.tar.gz* is the binary Python "sdist" > release. > > > > > > *apache_airflow-2.8.2-py3-none-any.whl* is the binary Python > wheel > > > > > "binary" > > > > > > release. > > > > > > > > > > > > Public keys are available at: > > > > > > https://eur03.safelinks.protection.outlook.com/?url=https%3A > > > > > > %2F%2Fdist.apache.org%2Frepos%2Fdist%2Frelease%2Fairflow%2FK > > > > > > EYS&data=05%7C02%7CJens.Scheffler%40de.bosch.com%7Cce83e167c > > > > > > b4d4d42c86e08dc3606d520%7C0ae51e1907c84e4bbb6d648ee58410f4%7 > > > > > > C0%7C0%7C638444650170695001%7CUnknown%7CTWFpbGZsb3d8eyJWIjoi > > > > > > MC4wLjAwMDAiLCJQIjoiV2luMzIiLCJBTiI6Ik1haWwiLCJXVCI6Mn0%3D%7 > > > > > > C0%7C%7C%7C&sdata=h4WZ5%2BSob0ooNqoftUIh1oc2fFTLz5NFaBjDYLBu > > > > > > o8c%3D&reserved=0 > > > > > > > > > > > > Please vote accordingly: > > > > > > > > > > > > [ ] +1 approve > > > > > > [ ] +0 no opinion > > > > > > [ ] -1 disapprove with the reason > > > > > > > > > > > > Only votes from PMC members are binding, but all members of > > > > > > the > > > > community > > > > > > are encouraged to test the release and vote with "(non-binding)". > > > > > > > > > > > > The test procedure for PMC members is described in: > > > > > > > > > > > > > > > > > > > > > > > > > > > https://gith/ > ub.com%2Fapache%2Fairflow%2Fblob%2Fmain%2Fdev%2FREADME_RELEASE_AIRFLOW > .md%2F%23verify-the-release-candidate-by-pmc-members&data=05%7C02%7CJe > ns.Scheffler%40de.bosch.com%7Cce83e167cb4d4d42c86e08dc3606d520%7C0ae51 > e1907c84e4bbb6d648ee58410f4%7C0%7C0%7C638444650170698512%7CUnknown%7CT > WFpbGZsb3d8eyJWIjoiMC4wLjAwMDAiLCJQIjoiV2luMzIiLCJBTiI6Ik1haWwiLCJXVCI > 6Mn0%3D%7C0%7C%7C%7C&sdata=loBQV7Ay8pfKOygQ1pRfa1yknMGOvrM8EmWRID1iaAk > %3D&reserved=0 > > > > > > > > > > > > The test procedure for and Contributors who would like to > > > > > > test > this > > > RC > > > > is > > > > > > described in: > > > > > > > > > > > > > > > > > > > > > > > > > > > https://gith/ > ub.com%2Fapache%2Fairflow%2Fblob%2Fmain%2Fdev%2FREADME_RELEASE_AIRFLOW > .md%2F%23verify-the-release-candidate-by-contributors&data=05%7C02%7CJ > ens.Scheffler%40de.bosch.com%7Cce83e167cb4d4d42c86e08dc3606d520%7C0ae5 > 1e1907c84e4bbb6d648ee58410f4%7C0%7C0%7C638444650170702452%7CUnknown%7C > TWFpbGZsb3d8eyJWIjoiMC4wLjAwMDAiLCJQIjoiV2luMzIiLCJBTiI6Ik1haWwiLCJXVC > I6Mn0%3D%7C0%7C%7C%7C&sdata=juvYDKhl9J7mNEJhFvyr45tDCBd3z%2FeyxlCgzh1Q > uhQ%3D&reserved=0 > > > > > > > > > > > > > > > > > > Please note that the version number excludes the `rcX` > > > > > > string, so > > > it's > > > > > now > > > > > > simply 2.8.2. This will allow us to rename the artifact > > > > > > without > > > > modifying > > > > > > the artifact checksums when we actually release. > > > > > > > > > > > > Release Notes: > > > > > > > https://gith/ > ub.com%2Fapache%2Fairflow%2Fblob%2F2.8.2rc3%2FRELEASE_NOTES.rst&data=0 > 5%7C02%7CJens.Scheffler%40de.bosch.com%7Cce83e167cb4d4d42c86e08dc3606d > 520%7C0ae51e1907c84e4bbb6d648ee58410f4%7C0%7C0%7C638444650170706477%7C > Unknown%7CTWFpbGZsb3d8eyJWIjoiMC4wLjAwMDAiLCJQIjoiV2luMzIiLCJBTiI6Ik1h > aWwiLCJXVCI6Mn0%3D%7C0%7C%7C%7C&sdata=ADj3tyRYNn7l466UOH1PczyUd5VJ0MY0 > T6FlB7KVu7k%3D&reserved=0 > > > > > > > > > > > > For information on what goes into a release please see: > > > > > > > > > > > > > > > > > > > > > > > > > > > https://gith/ > ub.com%2Fapache%2Fairflow%2Fblob%2Fmain%2Fdev%2FWHAT_GOES_INTO_THE_NEX > T_RELEASE.md&data=05%7C02%7CJens.Scheffler%40de.bosch.com%7Cce83e167cb > 4d4d42c86e08dc3606d520%7C0ae51e1907c84e4bbb6d648ee58410f4%7C0%7C0%7C63 > 8444650170710028%7CUnknown%7CTWFpbGZsb3d8eyJWIjoiMC4wLjAwMDAiLCJQIjoiV > 2luMzIiLCJBTiI6Ik1haWwiLCJXVCI6Mn0%3D%7C0%7C%7C%7C&sdata=Ku623ih6x1kiz > I6LiBHdbYC6VYr7D4KyCJm4v47ZbbY%3D&reserved=0 > > > > > > > > > > > > Changes since 2.8.2rc2: > > > > > > > > > > > > *Bugs*: > > > > > > - Fix regression on trigger form error display on form > > > > > > validation > > > > > (#37672) > > > > > > > > > > > > *Miscellaneous*: > > > > > > - Install latest docker ``CLI`` instead of specific one > > > > > > (#37651) > > > > > > > > > > > > Cheers, > > > > > > Ephraim > > > > > > > > > > > > > > > > > > > > >
