[
https://issues.apache.org/jira/browse/APEXCORE-401?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15221000#comment-15221000
]
ASF GitHub Bot commented on APEXCORE-401:
-----------------------------------------
Github user tweise commented on a diff in the pull request:
https://github.com/apache/incubator-apex-core/pull/290#discussion_r58154352
--- Diff: codestyle-config/pom.xml ---
@@ -0,0 +1,35 @@
+<?xml version="1.0" encoding="UTF-8"?>
+<!--
+
+ Licensed to the Apache Software Foundation (ASF) under one
+ or more contributor license agreements. See the NOTICE file
+ distributed with this work for additional information
+ regarding copyright ownership. The ASF licenses this file
+ to you under the Apache License, Version 2.0 (the
+ "License"); you may not use this file except in compliance
+ with the License. You may obtain a copy of the License at
+
+ http://www.apache.org/licenses/LICENSE-2.0
+
+ Unless required by applicable law or agreed to in writing,
+ software distributed under the License is distributed on an
+ "AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY
+ KIND, either express or implied. See the License for the
+ specific language governing permissions and limitations
+ under the License.
+
+-->
+<project xmlns="http://maven.apache.org/POM/4.0.0";
+ xmlns:xsi="http://www.w3.org/2001/XMLSchema-instance";
+ xsi:schemaLocation="http://maven.apache.org/POM/4.0.0
http://maven.apache.org/xsd/maven-4.0.0.xsd";>
+ <parent>
+ <groupId>org.apache.apex</groupId>
+ <artifactId>apex</artifactId>
+ <version>3.4.0-incubating-SNAPSHOT</version>
+ </parent>
+ <modelVersion>4.0.0</modelVersion>
+
+ <artifactId>apex-codesytle-config</artifactId>
--- End diff --
typo
> Create a separate artifact for checkstyle and other common configurations
> -------------------------------------------------------------------------
>
> Key: APEXCORE-401
> URL: https://issues.apache.org/jira/browse/APEXCORE-401
> Project: Apache Apex Core
> Issue Type: Improvement
> Reporter: Chandni Singh
> Assignee: Chandni Singh
>
> As of now, Apex Core and Apex Malhar have same checkstyle rules. These rules
> are present in a file called apex_checks.xml. There are separate copies of
> these present in both the repositories. Any change to the configuration has
> to be made manually at multiple places.
> We can improve this by creating another artifact which includes such common
> configuration and Apex Malhar can reference it directly.
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
