[
https://issues.apache.org/jira/browse/APEXCORE-401?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15221746#comment-15221746
]
ASF GitHub Bot commented on APEXCORE-401:
-----------------------------------------
Github user tweise commented on the pull request:
https://github.com/apache/incubator-apex-core/pull/290#issuecomment-204414197
#1 can be addressed by releasing the Maven artifact separately.
#2 should be solved in intellij
--
sent from mobile
On Apr 1, 2016 7:16 AM, "Vlad Rozov" <[email protected]> wrote:
> I see couple of issues that such approach will introduce:
>
> 1. Changes to the codestyle configuration will not be visible in
> Malhar till the next Apex release while Apex will be affected
immideately.
> 2. IntelliJ has codestyle plugin that relies on codestyle definition
> file location. When this file is moved to a different location,
switching
> between releases becomes quite inconvinient.
>
> —
> You are receiving this because you commented.
> Reply to this email directly or view it on GitHub
>
<https://github.com/apache/incubator-apex-core/pull/290#issuecomment-204412962>
>
> Create a separate artifact for checkstyle and other common configurations
> -------------------------------------------------------------------------
>
> Key: APEXCORE-401
> URL: https://issues.apache.org/jira/browse/APEXCORE-401
> Project: Apache Apex Core
> Issue Type: Improvement
> Reporter: Chandni Singh
> Assignee: Chandni Singh
>
> As of now, Apex Core and Apex Malhar have same checkstyle rules. These rules
> are present in a file called apex_checks.xml. There are separate copies of
> these present in both the repositories. Any change to the configuration has
> to be made manually at multiple places.
> We can improve this by creating another artifact which includes such common
> configuration and Apex Malhar can reference it directly.
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
