[
https://issues.apache.org/jira/browse/APEXCORE-401?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15222321#comment-15222321
]
ASF GitHub Bot commented on APEXCORE-401:
-----------------------------------------
Github user vrozov commented on a diff in the pull request:
https://github.com/apache/incubator-apex-core/pull/290#discussion_r58264813
--- Diff: pom.xml ---
@@ -335,6 +336,11 @@
<version>2.17</version>
<dependencies>
<dependency>
+ <groupId>org.apache.apex</groupId>
+ <artifactId>apex-codestyle-config</artifactId>
+ <version>${project.version}</version>
--- End diff --
Yes, I think `apex-codestyle-config` should be a separate project (source
code may still be part of Apex repository) with it's own version and release
cycle. It then can be released to maven prior to making changes to Apex pom.
> Create a separate artifact for checkstyle and other common configurations
> -------------------------------------------------------------------------
>
> Key: APEXCORE-401
> URL: https://issues.apache.org/jira/browse/APEXCORE-401
> Project: Apache Apex Core
> Issue Type: Improvement
> Reporter: Chandni Singh
> Assignee: Chandni Singh
>
> As of now, Apex Core and Apex Malhar have same checkstyle rules. These rules
> are present in a file called apex_checks.xml. There are separate copies of
> these present in both the repositories. Any change to the configuration has
> to be made manually at multiple places.
> We can improve this by creating another artifact which includes such common
> configuration and Apex Malhar can reference it directly.
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
