[
https://issues.apache.org/jira/browse/APEXCORE-401?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15221732#comment-15221732
]
ASF GitHub Bot commented on APEXCORE-401:
-----------------------------------------
Github user vrozov commented on the pull request:
https://github.com/apache/incubator-apex-core/pull/290#issuecomment-204412962
I see couple of issues that such approach will introduce:
1. Changes to the codestyle configuration will not be visible in Malhar
till the next Apex release while Apex will be affected immideately.
2. IntelliJ has codestyle plugin that relies on codestyle definition file
location. When this file is moved to a different location, switching between
releases becomes quite inconvinient.
> Create a separate artifact for checkstyle and other common configurations
> -------------------------------------------------------------------------
>
> Key: APEXCORE-401
> URL: https://issues.apache.org/jira/browse/APEXCORE-401
> Project: Apache Apex Core
> Issue Type: Improvement
> Reporter: Chandni Singh
> Assignee: Chandni Singh
>
> As of now, Apex Core and Apex Malhar have same checkstyle rules. These rules
> are present in a file called apex_checks.xml. There are separate copies of
> these present in both the repositories. Any change to the configuration has
> to be made manually at multiple places.
> We can improve this by creating another artifact which includes such common
> configuration and Apex Malhar can reference it directly.
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
