Quick update: after spending way too much time fighting Forrest I've managed to get the full build working on Docker to the point where all tests pass and all artifacts are created and signed. (If you're interested you can try it out by typing './build.sh docker', then './build.sh clean dist' in the Docker container.)
I had hoped to roll a release this week, and I'm travelling for the next two weeks so it will probably have to wait until I'm back. Cheers, Tom On Thu, Jul 9, 2015 at 4:13 PM, Tom White <t...@cloudera.com> wrote: > I committed the Ruby fixes that Sean reviewed, and I've looked at > Marcin's patch. Is anyone familiar with the C implementation able to > take a look at Thomas' patch? > > Thanks, > Tom > > On Thu, Jul 9, 2015 at 9:30 AM, Thomas Sanchez <thomas.san...@gmail.com> > wrote: >> Hi, >> Sorry to bust in, but if one could take a final look at AVRO-1663, I'd >> appreciate. >> It is a minor fix. >> >> Thanks, >> >> 2015-07-07 17:16 GMT+02:00 Sean Busbey <bus...@cloudera.com>: >>> I have done non-binding reviews on the following, if a committer could take >>> look: >>> >>> * AVRO-1645 >>> * AVRO-1693 >>> >>> On Tue, Jul 7, 2015 at 8:41 AM, Tom White <t...@cloudera.com> wrote: >>> >>>> Committers - please take a look at the outstanding patch available >>>> JIRAs for 1.7.8/1.8.0 and review and commit any that you'd like to see >>>> in 1.8.0: >>>> >>>> http://s.apache.org/xXz >>>> >>>> Thanks! >>>> Tom >>>> >>>> On Tue, Jul 7, 2015 at 2:34 PM, Tom White <t...@cloudera.com> wrote: >>>> > Thanks Niels. Comments inline. >>>> > >>>> > On Wed, Jul 1, 2015 at 3:50 PM, Niels Basjes <ni...@basjes.nl> wrote: >>>> >> Hi, >>>> >> >>>> >> I would say go for the 1.8.0 >>>> >> >>>> >> Note that there are a few issues that seem appropriate to include for >>>> >> this one because they relate to a change in 'backwards compatibility": >>>> >> >>>> >> - AVRO-1586 Build against Hadoop 2 >>>> >> ( which should also fix AVRO-1453 Release version of avro-tools >>>> >> compiled against hadoop2 ) >>>> >> - AVRO-1559 Drop support for Ruby 1.8 >>>> > >>>> > I've committed both of these now. >>>> > >>>> >> >>>> >> On a personal note I would like a 'Yes, commit' / 'No, won't fix' >>>> >> choice from you guys regarding this proposal (Patch included): >>>> >> AVRO-1633 Add additional setXxx(Builder) method to make user code >>>> >> more readable. >>>> > >>>> > I think this is a "won't fix" as it doesn't seem to produce any real >>>> > increase in readability and could actually be confusing. >>>> > >>>> > Thanks, >>>> > Tom >>>> > >>>> >> >>>> >> Niels Basjes >>>> >> >>>> >> On Wed, Jul 1, 2015 at 3:25 PM, Tom White <t...@cloudera.com> wrote: >>>> >>> Hi everyone, >>>> >>> >>>> >>> It would be good to do another Avro release soon. I'm happy to create >>>> >>> a release candidate so we can vote on it. >>>> >>> >>>> >>> What do folks think about releasing 1.7.8 vs. 1.8.0? There are very >>>> >>> few changes in the 1.7 branch, so it might be best to release 1.8.0 >>>> >>> from trunk. There have been enough changes to justify a new minor >>>> >>> release I think. Are there any drawbacks to doing that? >>>> >>> >>>> >>> The unresolved 1.8.0 issues are here: >>>> >>> >>>> >>> http://s.apache.org/Cdt >>>> >>> >>>> >>> And the unresolved 1.7.8 issues are here: >>>> >>> >>>> >>> http://s.apache.org/5ShO >>>> >>> >>>> >>> Thanks, >>>> >>> Tom >>>> >> >>>> >> >>>> >> >>>> >> -- >>>> >> Best regards / Met vriendelijke groeten, >>>> >> >>>> >> Niels Basjes >>>> >>> >>> >>> >>> -- >>> Sean >> >> >> >> -- >> Thomas Sanchez
