IMHO the jira should stay open as it's different from the PR. Regards JB
On Aug 16, 2017, 20:16, at 20:16, Ted Yu <yuzhih...@gmail.com> wrote: >What should be done to the JIRA associated with the PR? >-------- Original message --------From: Ahmet Altay ><al...@google.com.INVALID> Date: 8/16/17 12:05 PM (GMT-08:00) To: >dev@beam.apache.org Subject: Re: Policy for stale PRs >Sounds like we have consensus. Since this is a new policy, I would >suggest >picking the most flexible option for now (90 days) and we can tighten >it in >the future. To answer Kenn's question, I do not know, how other >projects >handle this. I did a basic search but could not find a good answer. > >What mechanism can we use to close PRs, assuming that author will be >out of >communication. We can push a commit with a "This closes #xyz #abc" >message. >Is there another way to do this? > >Ahmet > >On Wed, Aug 16, 2017 at 4:32 AM, Aviem Zur <aviem...@gmail.com> wrote: > >> Makes sense to close after a long time of inactivity and no response, >and >> as Kenn mentioned they can always re-open. >> >> On Wed, Aug 16, 2017 at 12:20 AM Jean-Baptiste Onofré ><j...@nanthrax.net> >> wrote: >> >> > If we consider the author, it makes sense. >> > >> > Regards >> > JB >> > >> > On Aug 15, 2017, 01:29, at 01:29, Ted Yu <yuzhih...@gmail.com> >wrote: >> > >The proposal makes sense. >> > > >> > >If the author of PR doesn't respond for 90 days, the PR is likely >out >> > >of >> > >sync with current repo. >> > > >> > >Cheers >> > > >> > >On Mon, Aug 14, 2017 at 5:27 PM, Ahmet Altay ><al...@google.com.invalid> >> > >wrote: >> > > >> > >> Hi all, >> > >> >> > >> Do we have an existing policy for handling stale PRs? If not >could we >> > >come >> > >> up with one. We are getting close to 100 open PRs. Some of the >open >> > >PRs >> > >> have not been touched for a while, and if we exclude the pings >the >> > >number >> > >> will be higher. >> > >> >> > >> For example, we could close PRs that have not been updated by >the >> > >original >> > >> author for 90 days even after multiple attempts to reach them >(e.g. >> > >[1], >> > >> [2] are such PRs.) >> > >> >> > >> What do you think? >> > >> >> > >> Thank you, >> > >> Ahmet >> > >> >> > >> [1] https://github.com/apache/beam/pull/1464 >> > >> [2] https://github.com/apache/beam/pull/2949 >> > >> >> > >>
