+1 On Fri, Jun 1, 2018 at 11:36 AM Ankur Goenka <goe...@google.com> wrote:
> +1 > > On Fri, Jun 1, 2018 at 11:28 AM Charles Chen <c...@google.com> wrote: > >> +1 >> >> On Fri, Jun 1, 2018 at 11:20 AM Valentyn Tymofieiev <valen...@google.com> >> wrote: >> >>> +1 >>> >>> On Fri, Jun 1, 2018 at 10:40 AM, Ahmet Altay <al...@google.com> wrote: >>> >>>> +1 >>>> >>>> On Fri, Jun 1, 2018 at 10:37 AM, Kenneth Knowles <k...@google.com> >>>> wrote: >>>> >>>>> +1 >>>>> >>>>> On Fri, Jun 1, 2018 at 10:25 AM Thomas Groh <tg...@apache.org> wrote: >>>>> >>>>>> As we seem to largely have consensus in "Reducing Committer Load for >>>>>> Code Reviews"[1], this is a vote to change the Beam policy on Code >>>>>> Reviews >>>>>> to require that >>>>>> >>>>>> (1) At least one committer is involved with the code review, as >>>>>> either a reviewer or as the author >>>>>> (2) A contributor has approved the change >>>>>> >>>>>> prior to merging any change. >>>>>> >>>>>> This changes our policy from its current requirement that at least >>>>>> one committer *who is not the author* has approved the change prior to >>>>>> merging. We believe that changing this process will improve code review >>>>>> throughput, reduce committer load, and engage more of the community in >>>>>> the >>>>>> code review process. >>>>>> >>>>>> Please vote: >>>>>> [ ] +1: Accept the above proposal to change the Beam code >>>>>> review/merge policy >>>>>> [ ] -1: Leave the Code Review policy unchanged >>>>>> >>>>>> Thanks, >>>>>> >>>>>> Thomas >>>>>> >>>>>> [1] >>>>>> https://lists.apache.org/thread.html/7c1fde3884fbefacc252b6d4b434f9a9c2cf024f381654aa3e47df18@%3Cdev.beam.apache.org%3E >>>>>> >>>>> >>>> >>> -- ------- Jason Kuster Apache Beam / Google Cloud Dataflow See something? Say something. go/jasonkuster-feedback
