[
https://issues.apache.org/jira/browse/BIGTOP-1249?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14034239#comment-14034239
]
jay vyas commented on BIGTOP-1249:
----------------------------------
Whats the best way to determine patch application ? At this point, we have 3
different types of patches:
{{patch -p0 < }}: as in BIGTOP-1201
{{git format-patch}} : as in BIGTOP-1221
{{patch -p1 < }}: like in BIGTOP-1316
Its not clear the best way to determine which patch format is which
programmatically. Any ideas here?
> Umbrella JIRA: Pre-commit hooks and automated Patch validation
> --------------------------------------------------------------
>
> Key: BIGTOP-1249
> URL: https://issues.apache.org/jira/browse/BIGTOP-1249
> Project: Bigtop
> Issue Type: Improvement
> Components: Build
> Affects Versions: 0.7.0
> Reporter: jay vyas
> Labels: hackathon
> Fix For: 0.8.0
>
>
> Lets automate some of the review process.
> - It will be good to add in some pre-commit hooks which check for ASF
> boilerplate on all files and trailing whitespace.
> - It will be also nice if the build server can run "mvn compile" and some
> other basic validation on the code base every time a patch is submitted,
> similar to the way apache hadoop is doing.
> I say lets start small: Maybe on the upcoming hack day in denver we can glue
> the basic JIRA monitoring together with a simple bash script, and iterate
> from there.
--
This message was sent by Atlassian JIRA
(v6.2#6252)
