[
https://issues.apache.org/jira/browse/BIGTOP-1249?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14038026#comment-14038026
]
Konstantin Boudnik commented on BIGTOP-1249:
--------------------------------------------
Having a standard is great, but it means that any new contributor will have to
first read into every single detail on how to contribute and if they won't
we'll be forced to reject their patches, etc.
As I said, standards are great, but they are usually not very flexible. I think
checking {{git apply}} and - if failed - followed by {{git apply -p0 }}, is a
more viable option. Agree?
> Umbrella JIRA: Pre-commit hooks and automated Patch validation
> --------------------------------------------------------------
>
> Key: BIGTOP-1249
> URL: https://issues.apache.org/jira/browse/BIGTOP-1249
> Project: Bigtop
> Issue Type: Improvement
> Components: Build
> Affects Versions: 0.7.0
> Reporter: jay vyas
> Labels: hackathon
> Fix For: 0.8.0
>
>
> Lets automate some of the review process.
> - It will be good to add in some pre-commit hooks which check for ASF
> boilerplate on all files and trailing whitespace.
> - It will be also nice if the build server can run "mvn compile" and some
> other basic validation on the code base every time a patch is submitted,
> similar to the way apache hadoop is doing.
> I say lets start small: Maybe on the upcoming hack day in denver we can glue
> the basic JIRA monitoring together with a simple bash script, and iterate
> from there.
--
This message was sent by Atlassian JIRA
(v6.2#6252)
