[
https://issues.apache.org/jira/browse/BIGTOP-1249?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14039414#comment-14039414
]
Konstantin Boudnik commented on BIGTOP-1249:
--------------------------------------------
A couple of the points to think about:
- git format-patch exist solely for the purpose of sending patches over email.
We don't do it.
- the reason why I am using {{git diff --no-prefix}} is because it's about 20
times fast for me to double click on a file name inside of the patch and then
paste it with a middle mouse click elsewhere. E.g. I am might want to look into
that file or whatever. If a patch is formatted with prefixes, i.e. has these
annoying 'a/' and 'b/' things - it makes my workflow _painfully_ slow: now I
need to jump around the string to remove the prefix. Any while I am *very*
proficient with command line and bash this little things slows everything into
molasses.
I understand that all people are different: some are never learned Meta-B or
^-A and won't even for the sake of their lives. And that's ok by me. However, I
don't want to be deliberately slowed down to a slowest common denominator.
Does it sound heartless? Perhaps. But I don't care - I have a very limited time
on this planet and I want to do what computers can't. And let them to take care
about mechanical, mundane, and honestly boring stuff like detecting patch
formats. So, I am strongly against the imposition of any patch formatting
restrictions. And I don't by that having a standard patch format will ease the
review process. If patch doesn't apply - noone will review it. If it does - who
cares how it was formatted as far as the code is right?
> Umbrella JIRA: Pre-commit hooks and automated Patch validation
> --------------------------------------------------------------
>
> Key: BIGTOP-1249
> URL: https://issues.apache.org/jira/browse/BIGTOP-1249
> Project: Bigtop
> Issue Type: Improvement
> Components: Build
> Affects Versions: 0.7.0
> Reporter: jay vyas
> Labels: hackathon
> Fix For: 0.8.0
>
>
> Lets automate some of the review process.
> - It will be good to add in some pre-commit hooks which check for ASF
> boilerplate on all files and trailing whitespace.
> - It will be also nice if the build server can run "mvn compile" and some
> other basic validation on the code base every time a patch is submitted,
> similar to the way apache hadoop is doing.
> I say lets start small: Maybe on the upcoming hack day in denver we can glue
> the basic JIRA monitoring together with a simple bash script, and iterate
> from there.
--
This message was sent by Atlassian JIRA
(v6.2#6252)
