[
https://issues.apache.org/jira/browse/BIGTOP-1249?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14038133#comment-14038133
]
jay vyas commented on BIGTOP-1249:
----------------------------------
We all agree we want to spur more contributions.... the question is wether the
benefits of rigorous use of {{git format-patch}} + {{git --signoff}} spurs more
contributions or makes it harder to contribute.
I think it spurs more contributions : here is why.
(1) it helps contributors by forcing them to get attributed for their work
because git puts your name and data in the commit log and also .
(2) makes it easier to validate patches. that makes it easier for
contributors because there is a clear deterministic way to evaluate their
patches.
To Cos' point, it does make it harder for some people ... But I think the
amount of people a standard **benefits** is >> then the amount it hinders.
So how bout a comprimise - we agree that {{git format-patch}} is the **right**
way to submit patches, we all agree to encourage it because of its obvious
benefits - but commiters can choose to accept and review other patches if they
want to... and maybe in time we can re-visit wether to strictly enforce a
standard or not at a later date.
> Umbrella JIRA: Pre-commit hooks and automated Patch validation
> --------------------------------------------------------------
>
> Key: BIGTOP-1249
> URL: https://issues.apache.org/jira/browse/BIGTOP-1249
> Project: Bigtop
> Issue Type: Improvement
> Components: Build
> Affects Versions: 0.7.0
> Reporter: jay vyas
> Labels: hackathon
> Fix For: 0.8.0
>
>
> Lets automate some of the review process.
> - It will be good to add in some pre-commit hooks which check for ASF
> boilerplate on all files and trailing whitespace.
> - It will be also nice if the build server can run "mvn compile" and some
> other basic validation on the code base every time a patch is submitted,
> similar to the way apache hadoop is doing.
> I say lets start small: Maybe on the upcoming hack day in denver we can glue
> the basic JIRA monitoring together with a simple bash script, and iterate
> from there.
--
This message was sent by Atlassian JIRA
(v6.2#6252)
