[ 
https://issues.apache.org/jira/browse/CLIMATE-341?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13906356#comment-13906356
 ] 

Maziyar Boustani commented on CLIMATE-341:
------------------------------------------

Thanks Alex, Mike and Cam,

So I am going to refactor the "calcAnnualCycleMeans" function to be able to 
calculate the annual means value of given dataset.

Couple Questions:

1- Does function name "AnnualMeans" sounds good?
2- Do we need to have a separate function like "reshapeMonthlyData" in [1] 
somewhere in [2]? (this will help to use "reshapeMonthlyData" to use multiple 
times if needed.)
3- I will return just the calculated means value and not the reshaped array any 
more, does that sounds good as well?


[1]: 
https://svn.apache.org/repos/asf/incubator/climate/trunk/rcmet/src/main/python/rcmes/utils/misc.py
[2]: https://svn.apache.org/repos/asf/incubator/climate/trunk/ocw/utils.py

> Refactoring metric "calcAnnualCycleMeans"
> -----------------------------------------
>
>                 Key: CLIMATE-341
>                 URL: https://issues.apache.org/jira/browse/CLIMATE-341
>             Project: Apache Open Climate Workbench
>          Issue Type: Sub-task
>          Components: metrics
>    Affects Versions: 0.3-incubating
>            Reporter: Maziyar Boustani
>            Assignee: Maziyar Boustani
>             Fix For: 0.4-incubating
>
>
> Refactoring metric "calcAnnualCycleMeans" from [1] to new metrics [2].
> [1]: 
> https://svn.apache.org/repos/asf/incubator/climate/trunk/rcmet/src/main/python/rcmes/toolkit/metrics.py
> [2]:https://svn.apache.org/repos/asf/incubator/climate/trunk/ocw/metrics.py



--
This message was sent by Atlassian JIRA
(v6.1.5#6160)

Reply via email to