[ 
https://issues.apache.org/jira/browse/CLIMATE-341?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13913156#comment-13913156
 ] 

Michael Joyce commented on CLIMATE-341:
---------------------------------------

Hay Mazi,

1) Yep that name seems fine to me
2) Sure. I would move the existing function over, clean up anything (like make 
the docstring match our current formatting), and write some tests for it.
3) yep

> Refactoring metric "calcAnnualCycleMeans"
> -----------------------------------------
>
>                 Key: CLIMATE-341
>                 URL: https://issues.apache.org/jira/browse/CLIMATE-341
>             Project: Apache Open Climate Workbench
>          Issue Type: Sub-task
>          Components: metrics
>    Affects Versions: 0.3-incubating
>            Reporter: Maziyar Boustani
>            Assignee: Maziyar Boustani
>             Fix For: 0.4-incubating
>
>
> Refactoring metric "calcAnnualCycleMeans" from [1] to new metrics [2].
> [1]: 
> https://svn.apache.org/repos/asf/incubator/climate/trunk/rcmet/src/main/python/rcmes/toolkit/metrics.py
> [2]:https://svn.apache.org/repos/asf/incubator/climate/trunk/ocw/metrics.py



--
This message was sent by Atlassian JIRA
(v6.1.5#6160)

Reply via email to