I agree with Prasanna on this. We don't need to introduce several Storage pool related responses just for some specific apis. In some way, suitableFormigration is some kind of attribute that can be set on a storage pool or not. If you don't want to show it to listStoragePool call, you can set that as null so that json serialization will ignore it.
Just my two cents. -min On 6/6/13 5:07 AM, "Devdeep Singh" <devdeep.si...@citrix.com> wrote: >Hi, > >StoragePoolResponse should really only be used for listing storage pools. >Putting a suitableformigration flag etc. makes it weird for other apis. >If tomorrow the response object is updated to include more statistics for >admin user to make a better decision, then such information gets pushed >in there which makes it unnatural for apis that just need the list of >storage pools. I am planning to update StoragePoolForMigrationResponse to >include the StoragePoolResponse object and any other flag; >suitableformigration in this case. I'll file a bug for the same. > >Regards, >Devdeep > >> -----Original Message----- >> From: Prasanna Santhanam [mailto:t...@apache.org] >> Sent: Tuesday, June 04, 2013 2:28 PM >> To: dev@cloudstack.apache.org >> Subject: Re: StoragePoolForMigrationResponse and StoragePoolResponse >> >> On Fri, May 31, 2013 at 06:28:39PM +0530, Prasanna Santhanam wrote: >> > On Fri, May 31, 2013 at 12:24:20PM +0000, Pranav Saxena wrote: >> > > Hey Prasanna , >> > > >> > > I see that the response object name is >> > > findstoragepoolsformigrationresponse , which is correct as shown >> > > below . Are you referring to this API or something else ? >> > > >> > > http://MSIP:8096/client/api?command=findStoragePoolsForMigration >> > > >> > > <findstoragepoolsformigrationresponse >> > > cloud-stack-version="4.2.0-SNAPSHOT"> >> > > >> > > </findstoragepoolsformigrationresponse> >> > > >> > >> > No that's what is shown to the user. I meant the class within >> > org.apache.cloudstack.api.response >> > >> Fixed with 0401774a09483354f5b8532a30943351755da93f >> >> -- >> Prasanna., >> >> ------------------------ >> Powered by BigRock.com >
