Will,
Here's another PR you might want to consider: https://github.com/apache/cloudstack/pull/1608 [https://avatars3.githubusercontent.com/u/1444686?v=3&s=400]<https://github.com/apache/cloudstack/pull/1608> Cleanup RBD contexts after exceptions to prevent potential agent crash by leprechau · Pull Request #1608 · apache/cloudstack<https://github.com/apache/cloudstack/pull/1608> github.com We noticed that when an exception occurs within the cleanup loop inside the deletePhysicalDisk routine that the previously allocated contexts are not cleaned up. This seemed to cause an eventual c... It fixes a segfault in the agent that we discovered when we had a misconfigured ceph ACL and also greatly improves logging. I see pdube also posted this PR: https://github.com/apache/cloudstack/pull/1609 We've pulled it in for testing. - Si - Si ________________________________ From: williamstev...@gmail.com <williamstev...@gmail.com> on behalf of Will Stevens <wstev...@cloudops.com> Sent: Tuesday, July 12, 2016 11:14 AM To: dev@cloudstack.apache.org Subject: Re: [VOTE] Apache Cloudstack 4.9.0 RC1 Thank you, so this RC has officially failed. Can you guys please review those PRs and give me code review so I can be confident with those PRs. I will run testing on those two PRs to make sure things don't break with them. Is there anything else that needs to be added to the next RC, please speak now so we can streamline this next RC. Thanks, *Will STEVENS* Lead Developer *CloudOps* *| *Cloud Solutions Experts 420 rue Guy *|* Montreal *|* Quebec *|* H3J 1S6 w cloudops.com *|* tw @CloudOps_ On Tue, Jul 12, 2016 at 10:53 AM, Sean Lair <sl...@ippathways.com> wrote: > Hi all, I vote -1 and would like to see the jdbc:mysql and site-to-site > vpn fixed in 4.9. > > https://github.com/apache/cloudstack/pull/1610 > https://github.com/apache/cloudstack/pull/1480 > > Thanks! > Sean > > -----Original Message----- > From: Wido den Hollander [mailto:w...@widodh.nl] > Sent: Tuesday, July 12, 2016 1:48 AM > To: Sean Lair <sl...@ippathways.com>; dev@cloudstack.apache.org > Subject: RE: [VOTE] Apache Cloudstack 4.9.0 RC1 > > > > Op 11 juli 2016 om 22:40 schreef Sean Lair <sl...@ippathways.com>: > > > > > > Hi all, > > > > One small comment since strongSwan didn't make it into 4.9. There is > still a very simple bug in enabling PFS for site-to-site VPNs. The code > checks the Dead Peer Detection (DPD) variable instead of the PFS variable > when determining whether or not to enable PFS for the site-to-site VPN. > > > > Here is the 1-line of code that is broken. You can see how it refers to > dpd to set pfs. > > > > file.addeq(" pfs=%s" % CsHelper.bool_to_yn(obj['dpd'])) > > > > This pull request fixes the issue, but was not merged since we were > going to strongSwan. It would be nice if this bug fix was put into 4.9.0 > > > > https://github.com/apache/cloudstack/pull/1480 > > > > Would it make you a -1 for you without this PR? If so, please vote -1 :) > > Wido > > > > > Thanks! > > Sean > > > > -----Original Message----- > > From: Will Stevens [mailto:williamstev...@gmail.com] > > Sent: Wednesday, July 6, 2016 3:52 PM > > To: dev@cloudstack.apache.org > > Subject: [VOTE] Apache Cloudstack 4.9.0 RC1 > > > > Hi All, > > > > I've created a 4.9.0 release, with the following artifacts up for a vote: > > > > Git Branch and Commit SH: > > > https://git-wip-us.apache.org/repos/asf?p=cloudstack.git;a=shortlog;h=refs/heads/4.9.0-RC20160706T1546 > > Commit: 643f75aa9150156b1fb05f339a338614fc7ad3fb > > > > I will be updating the Release Notes with the changes in this release > tomorrow. If the RC changes, I can adapt the release notes after. > > > > Source release (checksums and signatures are available at the same > > location): > > https://dist.apache.org/repos/dist/dev/cloudstack/4.9.0/ > > > > PGP release keys (signed using CB818F64): > > https://dist.apache.org/repos/dist/release/cloudstack/KEYS > > > > Vote will be open for 72 hours. > > > > For sanity in tallying the vote, can PMC members please be sure to > indicate "(binding)" with their vote? > > > > [ ] +1 approve > > [ ] +0 no opinion > > [ ] -1 disapprove (and reason why) > > > > Thanks, > > > > Will >
