On 28 September 2012 08:17, Jörg Schaible <joerg.schai...@scalaris.com> wrote: > Hi Sebb, > > sebb wrote: > >> On 27 September 2012 23:53, <joe...@apache.org> wrote: >>> Author: joehni >>> Date: Thu Sep 27 22:53:46 2012 >>> New Revision: 1391258 >>> >>> URL: http://svn.apache.org/viewvc?rev=1391258&view=rev >>> Log: >>> Use conversion tables for boolean arrays. >> >> I think the previous code was much clearer. >> >> At first sight it now looks as though the static arrays are shared >> (which would not be safe) but in fact they are cloned. > > At least I should have checked it with a profiler before. Don't we have a > YourKit license for Apache somewhere?
Is a hoped for performance gain why you made the change? Unless there is a significant improvement across several Java versions, I'm -1 on the change as the code is now more obscure. > - Jörg > > > --------------------------------------------------------------------- > To unsubscribe, e-mail: dev-unsubscr...@commons.apache.org > For additional commands, e-mail: dev-h...@commons.apache.org > --------------------------------------------------------------------- To unsubscribe, e-mail: dev-unsubscr...@commons.apache.org For additional commands, e-mail: dev-h...@commons.apache.org