sebb wrote: > On 28 September 2012 18:47, Jörg Schaible <joerg.schai...@gmx.de> wrote: >> sebb wrote: >>
[snip] >>> Unless there is a significant improvement across several Java >>> versions, I'm -1 on the change as the code is now more obscure. >> >> Done. > > Thanks! > >> Any comment on replacing the standard hex representation (i.e. lower case >> letters like JDK does)? > > 50/50 I tend to follow the JDK here. > But it needs to be documented better; e.g. intToHexDigitM0 does not > say whether output is upper or lower case. > > It's good that the code accepts either case on input. > > == > > I find the naming convention rather difficult to follow. > > For example, the letter 's' sometimes means 'array' and sometimes means > 'string' Also M0 is not obvious as an abbreviation, nor is BeM0 I am all open for better names, all *I* want to have is the functionality. - Jörg --------------------------------------------------------------------- To unsubscribe, e-mail: dev-unsubscr...@commons.apache.org For additional commands, e-mail: dev-h...@commons.apache.org
