Github user vladimir-kotikov commented on a diff in the pull request:
https://github.com/apache/cordova-lib/pull/425#discussion_r59346334
--- Diff: cordova-lib/src/plugman/fetch.js ---
@@ -132,8 +132,9 @@ function fetchPlugin(plugin_src, plugins_dir, options) {
));
}
// If not found in local search path, fetch from the registry.
- var splitVersion = plugin_src.split('@');
- var newID = pluginMapperotn[splitVersion[0]];
+ var splitVersion =
cordovaUtil.parseRegistryPluginSpec(plugin_src);
+ var oldId = splitVersion[0] || plugin_src;
+ var newID = pluginMapperotn[oldId];
--- End diff --
Since `oldId` could be either package id or scope + package id i'm not sure
how this will work with plugin mapper. Should we use `extractPluginId` instead
of `parseRegistryPluginSpec` in L135?
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscr...@cordova.apache.org
For additional commands, e-mail: dev-h...@cordova.apache.org
