Github user vladimir-kotikov commented on a diff in the pull request:
https://github.com/apache/cordova-lib/pull/425#discussion_r59347577
--- Diff: cordova-lib/src/plugman/fetch.js ---
@@ -205,8 +206,9 @@ function fetchPlugin(plugin_src, plugins_dir, options) {
// Helper function for checking expected plugin IDs against reality.
function checkID(expectedIdAndVersion, pinfo) {
if (!expectedIdAndVersion) return;
- var expectedId = expectedIdAndVersion.split('@')[0];
- var expectedVersion = expectedIdAndVersion.split('@')[1];
+ var parts = cordovaUtil.parseRegistryPluginSpec(expectedIdAndVersion);
+ var expectedId = parts[0] || expectedIdAndVersion;
+ var expectedVersion = parts[1];
if (expectedId != pinfo.id) {
--- End diff --
Since you use `parseRegistryPluginSpec`, it is possible that `expectedId`
would be specified as `@scope/id`, but from what i understand, pluginInfo.id
could not contain scope so this comparison will always be truthy in this case
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscr...@cordova.apache.org
For additional commands, e-mail: dev-h...@cordova.apache.org
