Github user vladimir-kotikov commented on a diff in the pull request:
https://github.com/apache/cordova-lib/pull/425#discussion_r59349270
--- Diff: cordova-lib/src/plugman/uninstall.js ---
@@ -145,10 +145,9 @@ module.exports.uninstallPlugin = function(id,
plugins_dir, options) {
var deps = pluginInfo.getDependencies();
var deps_path;
deps.forEach(function (d) {
- var splitVersion = d.id.split('@');
- deps_path = path.join(plugin_dir, '..', splitVersion[0]);
+ deps_path = path.join(plugin_dir, '..',
cordovaUtil.extractPluginId(d.id));
if (!fs.existsSync(deps_path)) {
- var newId = pluginMapper[splitVersion[0]];
+ var newId =
pluginMapper[cordovaUtil.parseRegistryPluginSpec(d.id)[0] || d.id];
--- End diff --
You use `extractPluginId` in L148 but `parseRegistryPluginSpec` here but
they will return different results in case if there is a scoped dependency in
plugin.xml. Is that intentional?
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscr...@cordova.apache.org
For additional commands, e-mail: dev-h...@cordova.apache.org
