[
https://issues.apache.org/jira/browse/COUCHDB-1289?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13156641#comment-13156641
]
Bob Dionne commented on COUCHDB-1289:
-------------------------------------
Filipe,
Ah, thanks, it looks like heartbeat was never supported in the feed="normal"
case. This next draft[1] handles this case also. I cherry-picked your cleaned
up etap to test with and it all passes. There is still a bug to fix and looking
at get_changes_timeout I see there are other cases missing, .eg. heartbeat
might be undefined and timeout infinity and I'm not dealing with {stop,
UsrAcc}. I've added the Timeout and TimeoutFun to the changes_acc record to try
and reduce the number of args to send_changes.
Anyway, it needs more simplifying and refactoring. I'll upload a patch when
there's something for you to review.
Cheers,
Bob
[1] https://github.com/bdionne/couchdb/compare/master...1289-heartbeats-skipped2
> heartbeats skipped when continuous changes feed filter function produces no
> results
> -----------------------------------------------------------------------------------
>
> Key: COUCHDB-1289
> URL: https://issues.apache.org/jira/browse/COUCHDB-1289
> Project: CouchDB
> Issue Type: Bug
> Components: Database Core
> Reporter: Bob Dionne
> Assignee: Bob Dionne
> Priority: Minor
> Attachments:
> 0001-Ensure-heartbeats-are-not-skipped-in-continuous-chan.patch
>
>
> if the changes feed has a filter function that produces no results,
> db_updated messages will still be sent and the heartbeat timeout will never
> be reached.
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators:
https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira
