[
https://issues.apache.org/jira/browse/COUCHDB-1289?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13157473#comment-13157473
]
Bob Dionne commented on COUCHDB-1289:
-------------------------------------
Thanks for the review Filipe. I pushed your changes on the branch[1]. I'll add
an additional etap for this case and rework the two patches when I return later
this morning. It's nice to get the maybe_timeout test into changes_enumerator
and out of the keep_sending_changes loop, as it makes both the continuous and
normal cases the same.
[1] https://github.com/bdionne/couchdb/commit/72cd7a5a214c0f1d810d7c9d8890645
> heartbeats skipped when continuous changes feed filter function produces no
> results
> -----------------------------------------------------------------------------------
>
> Key: COUCHDB-1289
> URL: https://issues.apache.org/jira/browse/COUCHDB-1289
> Project: CouchDB
> Issue Type: Bug
> Components: Database Core
> Reporter: Bob Dionne
> Assignee: Bob Dionne
> Priority: Minor
> Attachments: 0001-Ensure-heartbeats-are-not-skipped.patch,
> 0002-Failing-etap-for-heartbeats-skipped.patch
>
>
> if the changes feed has a filter function that produces no results,
> db_updated messages will still be sent and the heartbeat timeout will never
> be reached.
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators:
https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira
