[ https://issues.apache.org/jira/browse/COUCHDB-1289?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13158032#comment-13158032 ]
Filipe Manana commented on COUCHDB-1289: ---------------------------------------- Yep, so before we never called TimeoutFun for feed=normal, or better said, when folding the seq tree. I'm finding the existence of both a timeout and heartbeat quite confusing. But it makes sense to send heartbeats while folding the seq tree (if the client specified an heartbeat). As you said before as well, renaming "reset_timeout" to "reset_heartbeat" is saner. > heartbeats skipped when continuous changes feed filter function produces no > results > ----------------------------------------------------------------------------------- > > Key: COUCHDB-1289 > URL: https://issues.apache.org/jira/browse/COUCHDB-1289 > Project: CouchDB > Issue Type: Bug > Components: Database Core > Reporter: Bob Dionne > Assignee: Bob Dionne > Priority: Minor > Attachments: 0001-Ensure-heartbeats-are-not-skipped.patch, > 0002-Failing-etap-for-heartbeats-skipped.patch > > > if the changes feed has a filter function that produces no results, > db_updated messages will still be sent and the heartbeat timeout will never > be reached. -- This message is automatically generated by JIRA. If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa For more information on JIRA, see: http://www.atlassian.com/software/jira