[ 
https://issues.apache.org/jira/browse/RAT-472?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=18024739#comment-18024739
 ] 

Maxim Solodovnik commented on RAT-472:
--------------------------------------

Hello [~pottlinger],

sorry for delay it took some time to refresh my memories :)))

My steps were:

1. apply this patch to our master branch 
{{[email protected]:apache/openmeetings.git}} 
{{6576e034bb469e1d2f8ff8fcf0c53ea506786a2e}}
{code:language=diff}
diff --git a/pom.xml b/pom.xml
index cf7e7b7e8..1ed79d756 100644
--- a/pom.xml
+++ b/pom.xml
@@ -59,7 +59,7 @@
                <version.maven-antrun-plugin>3.1.0</version.maven-antrun-plugin>
                
<version.maven-resources-plugin>3.3.1</version.maven-resources-plugin>
                <version.maven-gpg-plugin>3.2.8</version.maven-gpg-plugin>
-               <version.apache-rat-plugin>0.16.1</version.apache-rat-plugin>
+               
<version.apache-rat-plugin>0.17-SNAPSHOT</version.apache-rat-plugin>
                
<version.checksum-maven-plugin>1.11</version.checksum-maven-plugin>
                
<version.maven-checkstyle-plugin>3.6.0</version.maven-checkstyle-plugin>
                <maven.compiler.target>${jdk.version}</maven.compiler.target>
@@ -414,6 +414,13 @@
                        <snapshots><enabled>true</enabled></snapshots>
                </repository>
        </repositories>
+       <pluginRepositories>
+               <pluginRepository>
+                       <id>apache.snapshots</id>
+                       
<url>https://repository.apache.org/content/repositories/snapshots</url>
+                       <snapshots><enabled>true</enabled></snapshots>
+               </pluginRepository>
+       </pluginRepositories>
        <dependencyManagement>
                <dependencies>
                        <dependency>
@@ -1495,7 +1502,7 @@
                                                        
<exclude>**/.project</exclude>
                                                        
<exclude>**/.classpath</exclude>
                                                        
<exclude>**/.settings/**</exclude>
-                                                       
<exclude>src/license/asf-license.txt</exclude>
+                                                       
<!--exclude>src/license/asf-license.txt</exclude-->
                                                        
<exclude>.gitattributes</exclude>
                                                </excludes>
                                        </configuration>
{code}

2. Run {{mvn clean install}}

Result:
{code}
[ERROR] Unexpected count for UNAPPROVED, limit is [0,0].  Count: 4
[INFO] UNAPPROVED (Unapproved) is a count of unapproved licenses.
[WARNING] *****************************************************
Generated at: 2025-10-05T12:05:24+07:00

Files with unapproved licenses:
  
/openmeetings-db/src/test/resources/org/apache/openmeetings/db/entity/file/6594186e-c6bb-49d5-9f66-829e45599aaa/6594186e-c6bb-49d5-9f66-829e45599aaa.pdf
  
/openmeetings-db/src/test/resources/org/apache/openmeetings/db/entity/file/d44ab2c5-fd5d-4903-8fa7-292286d72a5f/d44ab2c5-fd5d-4903-8fa7-292286d72a5f.pdf
  /openmeetings-web/src/main/webapp/images/deleted.pdf
  /src/license/asf-license.txt
{code}

I'll add {{*.pdf}} to the exclude list
But original ASF license doesn't pass the rat check :)))


> ASF license reported as non-compliant
> -------------------------------------
>
>                 Key: RAT-472
>                 URL: https://issues.apache.org/jira/browse/RAT-472
>             Project: Apache Rat
>          Issue Type: Bug
>            Reporter: Maxim Solodovnik
>            Priority: Major
>
> I've added https://apache.org/licenses/LICENSE-2.0.txt to our project sources
> NOTE: `APPENDIX: How to apply the Apache License to your work.` was *excluded*
> as a result {{org.apache.rat:apache-rat-plugin:0.16.1:check}} reports this 
> file as NON-ASF licensed :(((



--
This message was sent by Atlassian Jira
(v8.20.10#820010)

Reply via email to