stevedlawrence commented on a change in pull request #273: WIP: Add User Defined Functions Capability URL: https://github.com/apache/incubator-daffodil/pull/273#discussion_r331200431
########## File path: daffodil-test/src/test/java/org/goodudfs/example/StringFunctions/Replace.java ########## @@ -0,0 +1,21 @@ +package org.goodudfs.example.StringFunctions; + +import java.io.Serializable; + +import org.apache.daffodil.udf.FunctionClassInfo; + +@FunctionClassInfo( + name = "replace", + namespace = "com.ext.goodudfs.StringFunctions" Review comment: I'm not sure we want to tie it to package name. I believe this is the namespace as defined in the XML schema to call the function. It seems reasonable to allow the namespace to be something like "http://mycompany.com/udf-functions";, which can't be represented as a java namespace. In fact, these examples should probably use a XML style namespace since people will probably use these as examples. Maybe even change the name of this annotation property to "xmlNamespace" to make it clear. ---------------------------------------------------------------- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
