stevedlawrence commented on a change in pull request #273: WIP: Add User
Defined Functions Capability
URL: https://github.com/apache/incubator-daffodil/pull/273#discussion_r331489812
##########
File path:
daffodil-test/src/test/java/org/goodudfs/example/StringFunctions/StringFunctionsProvider.java
##########
@@ -0,0 +1,25 @@
+package org.goodudfs.example.StringFunctions;
+
+import org.apache.daffodil.udf.*;
+
+public class StringFunctionsProvider extends UDFunctionProvider {
+ public StringFunctionsProvider() {
+ super.setFunctionClasses( new Class<?>[] { Replace.class,
Compare.class } );
+ }
+
+ public Object lookupFunctionClass(String namespace, String name) {
+ Object functionClass = null;
+
+ String nn = String.join("_", namespace, name);
+
+ switch (nn) {
+ case "com.ext.UDFunction.StringFunctions_replace":
Review comment:
Looking at things more thoroughly, it seems a repetetive to need to call
setFunctionClasses and provide a lookupFunctionClass. That's two different ways
for the user to provide the list of Classes they support. Seems easier for a
user to just haave the setFunctionClasses thing to provide the list of classes
and then we can query them to get the name/namespace and figure out which one
we need to intantiate.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
With regards,
Apache Git Services
