stevedlawrence commented on a change in pull request #273: WIP: Add User 
Defined Functions Capability
URL: https://github.com/apache/incubator-daffodil/pull/273#discussion_r331478411
 
 

 ##########
 File path: 
daffodil-core/src/main/scala/org/apache/daffodil/dpath/Expression.scala
 ##########
 @@ -1870,6 +1871,47 @@ case class FunctionCallExpression(functionQNameString: 
String, expressions: List
       case (RefQName(_, "unsignedByte", XSD), args) =>
         XSConverterExpr(functionQNameString, functionQName, args, 
NodeInfo.UnsignedByte)
 
+      case (RefQName(Some(_), _, _), args) => {
 
 Review comment:
   The first ``Some(_)`` requires that there be a prefix for the UDF, but that 
isn't strictly necessary. I think it should be possible for someone to have the 
default namespace of a schema be the same as their udf namespace, in which case 
a prefix isn't necessary. I think this can just be ``case (RefQName(_, _, _), 
args) =>``

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services

Reply via email to