I agree we should do the release. I am in the thick of debugging DAFFODIL-1422, but there's a bunch of refactoring here, 30 files touched, changes in diagnostic behavior, etc. Perhaps best to put it off until after the 3.1.0 release.
________________________________ From: Steve Lawrence <slawre...@apache.org> Sent: Monday, May 10, 2021 1:59 PM To: dev@daffodil.apache.org <dev@daffodil.apache.org> Subject: Re: release 3.1.0 critical bugs still outstanding We have fixed the later two mentioned issues. The current list of critical issues is now: DAFFODIL-1422: disallow doctype decls in all XML & XSD that we read in DAFFODIL-2400: New SAX API causes performance degredations. DAFFODIL-2473: Need bit-wise AND, OR, NOT, and shift operations I agree the the first two can likely be postponed without issue. The last one doesn't even seem critical to me, unless there are very important formats that require this functions that I'm not aware of. I suggest we also postpone that ticket as well. If others agree, I think we are ready for the 3.1.0 release? Does any want to volunteer to be the release manager? I've done it a handful of times so don't mind, but it might be good to get others experience depending on availability. By this point, the workflow is pretty well documented here: https://cwiki.apache.org/confluence/display/DAFFODIL/Release+Workflow On 5/3/21 5:25 PM, Beckerle, Mike wrote: > Of the 4 remaining "critical bugs or improvements" I think we should postpone > and release note these first two: > > * > > * Improvement: https://issues.apache.org/jira/browse/DAFFODIL-2400 - New > SAX API causes performance degradations. > * It is a mystery why the SAX API is slower. The whole point of SAX > is lighter weight. > * Improvement: https://issues.apache.org/jira/browse/DAFFODIL-1422 - > disallow doctype decls in all XML and XSD we read in. > * Assigned to Mike Beckerle. Unlikely to be finished in time for > release 3.1.0. Substantial code refactoring to do this right. > > These next two seem rather important to fix: > > * Bug: https://issues.apache.org/jira/browse/DAFFODIL-2183 - Unparse > complex nilled element fails > * There are data formats where I advised people a best-practice is to > use complex nilled elements to model a specific situation. > * Bug: https://issues.apache.org/jira/browse/DAFFODIL-2399 - error > diagnostics output even though there is an infoset > * This one is assigned to Steve Lawrence > * Seems rather important. Was a user-reported issue I believe. > > The 5th critical ticket is for a new feature (bitwise and/or/xor, and shift > functions), so we can postpone that one. > > So only DAFFODIL-2183 really needs someone to take it on. > > ________________________________ > From: Interrante, John A (GE Research, US) <john.interra...@ge.com> > Sent: Monday, May 3, 2021 4:57 PM > To: dev@daffodil.apache.org <dev@daffodil.apache.org>... > > Are any of the 5 critical bugs (2 of which need developers to work on them) > going to hold up the 3.1.0 release? The report doesn't say so, but I had the > impression you'd added the remaining critical bugs (which were unlikely to be > hit by people) to the 3.1.0 release notes so that the 3.1.0 release still > could go out. If any critical bugs are holding up 3.1.0, please post links > to them so we can help if we have time. > > John > > >
