On Thu, Feb 16, 2017 at 9:44 PM, Matthew Hayes <[email protected]> wrote: > Following up on the LICENSE/NOTICE file issues in the binary artifacts, I > have prepared a patch that includes them in the artifacts, as well as the > DISCLAIMER: > > https://issues.apache.org/jira/browse/DATAFU-121 > https://reviews.apache.org/r/56779/ > > Justin and Roman, if you have time can you review these changes?
+1. Manually verified your change and the correct META-INF content was observed for both jars > Feedback > from others is welcome too. I'll explain how I prepared these: > > 1) Both datafu-hourglass and datafu-pig include LICENSE, NOTICE, and > DISCLAIMER files under META-INF inside the JARs. The DISCLAIMER is the > same for each. For the the other two files they are different. > 2) datafu-hourglass JAR does not bundle any dependencies, so the LICENSE > and NOTICE files are boilerplate. Makes sense > 3) datafu-pig JAR bundles several Apache-2.0-licensed JARs (and no > non-Apache-2.0 licensed JARs). I reviewed the LICENSE and NOTICE files for > each of the bundled dependencies. The only case I found where there was a > non-boilerplate LICENSE/NOTICE provided was Apache commons-math. I copied > the NOTICE and LICENSE contents to the datafu-pig JAR's NOTICE and LICENSE > files, respectively. I manually compared these two and it looks OK to me. > 4) I disabled generation of sources and javadoc JARs to avoid the build > issues I was experiencing trying to package these LICENSE and NOTICE > files. We can enable these later once the issues are resolved. Sounds good. Thanks, Roman.
