Gotcha. Cancelling the vote. Will address the concerns in new RC. Thanks John!
- Sijie On Thu, Jan 26, 2017 at 5:46 PM, John D. Ament <johndam...@apache.org> wrote: > On Thu, Jan 26, 2017 at 8:27 PM Sijie Guo <si...@apache.org> wrote: > > > On Thu, Jan 26, 2017 at 6:06 AM, John D. Ament <johndam...@apache.org> > > wrote: > > > > > Its not clear if you intended this to be the IPMC vote or the dev vote. > > > > > > > Sorry. it is my first time doing incubator project release. If I made > > something wrong, please let me know. > > > > This is vote is intended to for the IPMC vote. > > > > > > > > > > -1 Since the release does not include the DISCLAIMER file and README > does > > > not include the DISCLAIMER text (either would be fine per policy, but > > > generally we look for DISCLAIMER). > > > > > > > Gotcha. We will try to add this. > > > > > > > > > > There were no binaries in the source. > > > > > > The source package only includes source codes. The binaries are shipped > as > > two separated packages, one is service package, the other one is > benchmark > > package. Is there a policy about packaging? > > > > > > > NOTICE should be updated for 2017. > > > > > > > Will update this. > > > > > > > I'm not sure why the NOTICE includes Hadoop references. Do you still > > ship > > > modified versions? > > > > > > > Ah, here is the discussion about the NOTICE includes Hadoop references. > > > > http://mail-archives.apache.org/mod_mbox/incubator- > distributedlog-dev/201701.mbox/browser > > > > I think we are following what other projects were doing when we are > making > > a similar code change. And there is a JIRA to follow up after this > release. > > Do you see a major concern here? If so, we will address it in the new RC. > > > > > Yes. the incubation policies are pretty clear - > http://incubator.apache.org/incubation/Incubation_Policy.html#Releases > Missing disclaimer is all I see as an issue. I believe if you fix this, > you should be good. > > > > Thanks, > > > > Sijie > > > > > > > > > > > > On Thu, Jan 26, 2017 at 1:36 AM Sijie Guo <si...@apache.org> wrote: > > > > > > > Hi everyone, > > > > > > > > Please review and vote on the release candidate #2 for the Apache > > > > DistributedLog version 0.4.0-incubating, as follows: > > > > [ ] +1, Approve the release > > > > [ ] -1, Do not approve the release (please provide specific > > comments) > > > > > > > > > > > > The complete staging area is available for your review, which > > > includes: > > > > * JIRA release notes [1], > > > > * the official Apache source release to be deployed to > > > dist.apache.org > > > > [2], > > > > * all artifacts to be deployed to the Maven Central Repository > > > [3][4], > > > > * source code tag "v0.4.0-RC0" [4], > > > > * code tag "v0.4.0-incubating-RC1_2.11" (for scala 2.11) and > > > > "v0.4.0-incubating-RC1_2.10" (for scala 2.10) [5][6], > > > > * website pull request listing the release [7] and publishing the > > API > > > > reference manual. > > > > > > > > The Apache DistributedLog community has unanimously approved this > > > > release [8]. > > > > > > > > As customary, the vote will be open for at least 72 hours. It is > > > > adopted by > > > > a majority approval with at least three PMC affirmative votes. If > > > > approved, > > > > we will proceed with the release. > > > > > > > > Thanks! > > > > > > > > [1] https://issues.apache.org/jira/secure/ReleaseNote.jspa?p > > > > rojectId=12320620&version=12337980 > > > > [2] https://dist.apache.org/repos/dist/dev/incubator/ > > > distributedlog/0.4.0- > > > > incubating-RC2/ > > > > < > > https://dist.apache.org/repos/dist/dev/incubator/distributedlog/0.4.0- > > > incubating-RC2/> > > > > [3] https://repository.apache.org/content/repositories/ > > > > orgapachedistributedlog-1003/ > > > > [4] https://repository.apache.org/content/repositories/ > > > > orgapachedistributedlog-1004/ > > > > [5] https://github.com/apache/incubator-distributedlog/tree/ > > > > v0.4.0-incubating-RC1_2.11 > > > > [6] https://github.com/apache/incubator-distributedlog/tree/ > > > > v0.4.0-incubating-RC1_2.10 > > > > [7] https://github.com/apache/incubator-distributedlog/pull/109 > > > > [8] > > > > > > > > http://mail-archives.apache.org/mod_mbox/incubator- > > > distributedlog-dev/201701.mbox/%3CCAO2yDyYwQgg%3DSRuBdxTPC% > > > 3DT3bkZO4O0EULwq9tUB_Uno01XW7A%40mail.gmail.com%3E > > > > > > > > > >
