Github user paul-rogers commented on a diff in the pull request:
https://github.com/apache/drill/pull/909#discussion_r134098584
--- Diff:
exec/java-exec/src/test/java/org/apache/drill/exec/record/TestMaterializedField.java
---
@@ -84,4 +89,22 @@ public void testClone() {
}
+ @Test // DRILL-4264
+ public void testSchemaPathToMaterializedFieldConverting() {
--- End diff --
No test here for names with dots?
Also, still not convinced of the semantics: not sure we want to create a
tree of maps given a nested path. Instead, we need a way to refer to an
existing tree and either navigate down that tree to find existing maps, or
create a map as needed when a node is missing.
Note that much work has been done in this area in PR #914.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at [email protected] or file a JIRA ticket
with INFRA.
---
