[GitHub] drill pull request #909: DRILL-4264: Allow field names to include dots

[vvysotskyi]

Github user vvysotskyi commented on a diff in the pull request:

    https://github.com/apache/drill/pull/909#discussion_r134689741
  
    --- Diff: 
exec/java-exec/src/main/java/org/apache/drill/exec/physical/impl/project/ProjectRecordBatch.java
 ---
    @@ -362,16 +363,16 @@ protected boolean setupNewSchema() throws 
SchemaChangeException {
                   final TransferPair tp = vvIn.makeTransferPair(vvOut);
                   transfers.add(tp);
                 }
    -          } else if (value != null && value.intValue() > 1) { // 
subsequent wildcards should do a copy of incoming valuevectors
    +          } else if (value != null && value > 1) { // subsequent wildcards 
should do a copy of incoming valuevectors
                 int k = 0;
                 for (final VectorWrapper<?> wrapper : incoming) {
                   final ValueVector vvIn = wrapper.getValueVector();
    -              final SchemaPath originalPath = 
SchemaPath.getSimplePath(vvIn.getField().getPath());
    -              if (k > result.outputNames.size()-1) {
    +              final SchemaPath originalPath = 
SchemaPath.getSimplePath(vvIn.getField().getName());
    +              if (k > result.outputNames.size() - 1) {
                     assert false;
                   }
                   final String name = result.outputNames.get(k++);  // get the 
renamed column names
    -              if (name == EMPTY_STRING) {
    +              if (EMPTY_STRING.equals(name)) {
    --- End diff --
    
    Thanks, replaced by `name.isEmpty()`, but `EMPTY_STRING` is used in other 
places, so left it in the class.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---