Github user vvysotskyi commented on a diff in the pull request:
https://github.com/apache/drill/pull/909#discussion_r134788014
--- Diff:
exec/java-exec/src/test/java/org/apache/drill/test/rowSet/RowSetSchema.java ---
@@ -94,12 +102,20 @@ private void updateStructure(int index, PhysicalSchema
children) {
*/
public static class NameSpace<T> {
- private final Map<String,Integer> nameSpace = new HashMap<>();
+ private final Map<String, Integer> nameSpace = new HashMap<>();
private final List<T> columns = new ArrayList<>();
- public int add(String key, T value) {
+ /**
+ * Adds column path with specified value to the columns list
+ * and returns the index of the column in the list.
+ *
+ * @param key full name path of the column in the schema
+ * @param value value to be added to the list
+ * @return index of the column in the list
+ */
+ public int add(String[] key, T value) {
int index = columns.size();
- nameSpace.put(key, index);
+ nameSpace.put(SchemaPath.getCompoundPath(key).toExpr(), index);
--- End diff --
Thanks for the explanation, reverted my changes.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at [email protected] or file a JIRA ticket
with INFRA.
---
