Github user paul-rogers commented on a diff in the pull request:
https://github.com/apache/drill/pull/909#discussion_r134064098
--- Diff:
exec/java-exec/src/main/java/org/apache/drill/exec/vector/complex/SchemaPathUtil.java
---
@@ -0,0 +1,59 @@
+/*
+* Licensed to the Apache Software Foundation (ASF) under one or more
+* contributor license agreements. See the NOTICE file distributed with
+* this work for additional information regarding copyright ownership.
+* The ASF licenses this file to you under the Apache License, Version 2.0
+* (the "License"); you may not use this file except in compliance with
+* the License. You may obtain a copy of the License at
+*
+* http://www.apache.org/licenses/LICENSE-2.0
+*
+* Unless required by applicable law or agreed to in writing, software
+* distributed under the License is distributed on an "AS IS" BASIS,
+* WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
+* See the License for the specific language governing permissions and
+* limitations under the License.
+*/
+package org.apache.drill.exec.vector.complex;
+
+import org.apache.drill.common.expression.PathSegment;
+import org.apache.drill.common.expression.SchemaPath;
+import org.apache.drill.common.types.TypeProtos;
+import org.apache.drill.common.types.Types;
+import org.apache.drill.exec.record.MaterializedField;
+
+public class SchemaPathUtil {
+
+ /**
+ * Creates {@code MaterializedField} instance with {@code SchemaPath
path} name and children.
+ *
+ * @param path the source of field name and children
+ * @param type field type
+ * @return {@code MaterializedField} instance with name and children
+ * from the specified {@code SchemaPath path}
+ */
+ public static MaterializedField
getMaterializedFieldFromSchemaPath(SchemaPath path,
+
TypeProtos.MajorType type) {
+ return getMaterializedFieldFromPathSegment(path.getRootSegment(),
type);
+ }
+
+ /**
+ * Creates {@code MaterializedField} instance with {@code
SchemaPath.NameSegment path} name and children.
+ *
+ * @param path the source of field name and children
+ * @param type field type
+ * @return {@code MaterializedField} instance with name and children
+ * from the specified {@code PathSegment.NameSegment path}
+ */
+ public static MaterializedField
getMaterializedFieldFromPathSegment(PathSegment.NameSegment path,
+
TypeProtos.MajorType type) {
+ if (path.isLastPath()) {
+ return MaterializedField.create(path.getPath(), type);
+ } else {
+ MaterializedField field = MaterializedField.create(path.getPath(),
--- End diff --
Not at all sure that we want to do this. Suppose I have names `a.b`, and
`a.c`. Do I really want to have both create their own map fields for `a`? Not
very likely. Instead, I'd want to create the field for the map `a`, then add to
that fields for `b` and `c`.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---
