arina-ielchiieva commented on a change in pull request #1345: DRILL-6494: Drill
Plugins Handler
URL: https://github.com/apache/drill/pull/1345#discussion_r198854651
##########
File path:
exec/java-exec/src/main/java/org/apache/drill/exec/store/StoragePluginRegistryImpl.java
##########
@@ -194,25 +215,21 @@ public void init() throws DrillbitStartupException {
* @param config plugin config
* @param plugin plugin implementation
*/
-
- public void definePlugin(String name, StoragePluginConfig config,
StoragePlugin plugin) {
- addPlugin(name, plugin);
- definePluginConfig(name, config);
- }
-
- private boolean definePluginConfig(String name, StoragePluginConfig config) {
- return pluginSystemTable.putIfAbsent(name, config);
+ @VisibleForTesting
+ public void addPluginTonPersistenceStoreIfAbsent(String name,
StoragePluginConfig config, StoragePlugin plugin) {
Review comment:
Rename: `addPluginToPersistentStoreIfAbsent`.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
With regards,
Apache Git Services
