arina-ielchiieva commented on a change in pull request #1345: DRILL-6494: Drill
Plugins Handler
URL: https://github.com/apache/drill/pull/1345#discussion_r198848825
##########
File path:
common/src/main/java/org/apache/drill/common/exceptions/DrillIOException.java
##########
@@ -19,24 +19,23 @@
import java.io.IOException;
-public class DrillIOException extends IOException{
+public class DrillIOException extends IOException {
static final org.slf4j.Logger logger =
org.slf4j.LoggerFactory.getLogger(DrillIOException.class);
public DrillIOException() {
super();
}
- public DrillIOException(String message, Throwable cause) {
- super(message, cause);
+ public DrillIOException(Throwable cause, String formatMessage,
Object...args) {
Review comment:
Usually message comes before cause. Though you consider that making this
change is more convenient, in reality you are making things more confusing.
Please revert.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
With regards,
Apache Git Services
